Split damage calc in 2 for spells with travel time#946
Closed
Polynomix wants to merge 9 commits intowowsims:masterfrom
Closed
Split damage calc in 2 for spells with travel time#946Polynomix wants to merge 9 commits intowowsims:masterfrom
Polynomix wants to merge 9 commits intowowsims:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now target modifiers are snapshotted at the end of the cast for spells with travel time instead of when the spell hit the target. This means wrong damage when the target gain/lose mods during travel time.
This moves armor damage reduction and target modifiers to after the spell finished its travel time