Frost Mage Spec Fixes for MOP by BadJukeBox · Pull Request #96 · wowsims/mop

BadJukeBox · 2025-05-19T03:03:37Z

Current To Do List:

Frost and Frost adjacent spells:

Passives:

Fingers of Frost
Brain Freeze
Mastery: Icicles
Wizardry?

Talents:

Glyphs:

APL:

APL

… a larger Frost Spec implementation.

…currently.

…lues so I'm not buffing spells by insane values!

…ariables to be cleaner.

… it's correct but I think it's better

1337LutZ · 2025-06-09T08:04:29Z

@@ -38,31 +33,31 @@ export const P1_EP_PRESET = PresetUtils.makePresetEpWeights(
 // Default talents. Uses the wowhead calculator format, make the talents on


You might also want to look into P1_EP_PRESET, but if you are not comfortable in how EP works then you can comment this out for the time being.

…to preserve buff deactivate and still work as intended with icy veins. Icicle handling for normal case with splitting ice as intended, exposing set bonus to APL. Fixing the logic in Living bomb to check if the target in question already has a living bomb on them before we append to the array of active living bombs. Brain freeze logic simplification.

InDebt · 2025-06-09T20:32:33Z

+			BaseCostPercent: 1.5,
 		},
 		Cast: core.CastConfig{
 			DefaultCast: core.Cast{


Living bomb has a 1 sec GCD btw in mop - saw this when reviewing the Living Bomb issue

Good catch, I gotta look out to see if anything else is the same way.

BadJukeBox · 2025-06-09T21:01:20Z

For Living Bomb I noticed the ticks don't seem to ever proc brain freeze, only the initial cast of the spell, which is backwards. Should I make a separate livingbob ticket mask to solve this, or just move the proc chance into the OnTick function? Curious if there's a "best way"

1337LutZ · 2025-06-10T06:34:32Z

For Living Bomb I noticed the ticks don't seem to ever proc brain freeze, only the initial cast of the spell, which is backwards. Should I make a separate livingbob ticket mask to solve this, or just move the proc chance into the OnTick function? Curious if there's a "best way"

I would make a SpellMask for the Tick and handle it in a ProcTrigger

Feature/warrior

Initial Implementation of Fingers of Frost and Brain Freeze

b9588dd

github-actions Bot added the Mage label May 19, 2025

BadJukeBox changed the title ~~[Draft] Initial Implementation of Fingers of Frost and Brain Freeze~~ [Draft] Frost Mage Spec Fixes for MOP May 19, 2025

WIP commit Im going to break out the T14 into a separate MR

59916e1

InDebt reviewed May 19, 2025

View reviewed changes

Comment thread sim/mage/frost/fingers_of_frost.go

BadJukeBox added 4 commits May 18, 2025 22:33

Attempting a pass at Implementing the T14 Tier set bonuses as part of…

2d50ab4

… a larger Frost Spec implementation.

Actually adding cata Tier back in to keep it as additive as possible …

5fa24da

…currently.

Updating Pyroblast to include Dot, AM to be the Tick, fixing float va…

c2cfa5d

…lues so I'm not buffing spells by insane values!

Merge branch 'feature/mage-t14-set-bonus' into feature/frost-mage

4f8a3ce

BadJukeBox changed the base branch from master to feature/mage May 20, 2025 03:23

BadJukeBox added 2 commits May 19, 2025 20:53

FrostFire Bolt Changes, including Glyph cast speed reduction.

36c0e34

Frostbolt changes, fixing some Frostfire Bolt Changes, dragging out v…

70b5d5e

…ariables to be cleaner.

BadJukeBox marked this pull request as draft May 20, 2025 17:10

Frozen Orb Implementation, based on flame orb but slightly different.

2c0f53a

github-actions Bot added the Monk label May 20, 2025

BadJukeBox force-pushed the feature/frost-mage branch from 297444d to 2c0f53a Compare May 20, 2025 23:00

github-actions Bot removed the Monk label May 20, 2025

BadJukeBox added 4 commits May 20, 2025 16:30

Ice Lance Update, small frostbolt comment change

0483072

Cone of Cold and Frost Nova

f933b2c

Living bomb update for MOP

0971a67

A shoddy attempt at Frost Bomb

feb898f

BadJukeBox commented May 21, 2025

View reviewed changes

Comment thread sim/mage/frost_bomb.go

BadJukeBox added 4 commits May 21, 2025 16:46

Icy Veins

01f2d85

Armors initial pass, I'm fairly certain there are some incorrect bits.

76c73fe

small frozen Orb change, and fingers of frost update, still unsure if…

1431cbc

… it's correct but I think it's better

brain freeze, but i'm not sure how the sim buff gets deactivated.

c2382ef

1337LutZ reviewed May 23, 2025

View reviewed changes

Comment thread sim/mage/_frostfire_bolt.go Outdated

1337LutZ reviewed May 23, 2025

View reviewed changes

Comment thread sim/mage/_talents_arcane.go Outdated

1337LutZ reviewed May 23, 2025

View reviewed changes

Comment thread sim/mage/_talents_frost.go Outdated

1337LutZ reviewed May 23, 2025

View reviewed changes

Comment thread sim/mage/cone_of_cold.go