Skip to content

Change WPeC customer cookie performance and synchronicity #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeffPyeBrook wants to merge 1 commit into from
Closed

Change WPeC customer cookie performance and synchronicity #1598

JeffPyeBrook wants to merge 1 commit into from

Conversation

@JeffPyeBrook
Copy link
Contributor

@JeffPyeBrook JeffPyeBrook commented Oct 28, 2014

  • Wrap the check for the WPeC customer cookie in a function
  • Rather than check for the customer cookie on the page load set a timer that should cause the cookie check to happen very shortly after the ready event processing completes
  • Fix parsing of the customer cookie check response to retrieve the customer id from the AJAX response generated with the PHP function wp_send_json_success
  • When the cookie is present it is parsed to extract the WPeC customer id, this ensures that the customer ID is set when the cookie is present just the same as when the cookie is being created
  • Added some console messages to aid WPeC customer support in tracking down performance and reliability issues that have been reported in the WordPress support forum during the summer/fall of 2014
  • Added timeout value and a comment in the source that be enabled if a site wants to allow processing to move forward without setting the customer id in the javascript

Fix for issue #1597

@JeffPyeBrook
Change WPeC customer cookie performance and synchronicity
6d84f4b 
* Wrap the check for the WPeC customer cookie in a function
* Rather than check for the customer cookie on the ready event the ready event sets a timer to cause the cookie check to happen very shortly after the ready event processing completes
* Fix parsing of the customer cookie check response to retrieve the customer id from the AJAX response generated with the PHP function wp_send_json_success
* When the cookie is present it is parsed to extract the WPeC customer id, this ensures that the customer ID is set when the cookie is present jsut the same as when the cookie is being created
* Added some console messages to aid WPeC customer support in tracking down performance and reliability issues that have been reported in the WordPress support forum during the summer/fall of 2014
* Added time out value to HTTP request, commented out with a note for the site owner
@JeffPyeBrook
Copy link
Contributor Author

JeffPyeBrook commented Jan 12, 2015

@JustinSainton do want this PR? if not i won't bother rebasing it

@JeffPyeBrook JeffPyeBrook self-assigned this Jan 12, 2015
@JeffPyeBrook
Copy link
Contributor Author

JeffPyeBrook commented Mar 17, 2015

superseded by PR #1802 and PR #1787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JeffPyeBrook JeffPyeBrook

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JeffPyeBrook