Dont make variations database requests calls when variations aren't being used #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l arrays Add check to see if variations are defined and used, when they are not defined and used don't make calls through WordPress for variation terms unless working inside the admin area. Avoids lots of small empty queries.
Contributor
Author
|
@JustinSainton along the same lines as the PR we did last night, this PR avoids many similar small unnecessary database calls when product variations are not being used. I recall having mentioned it to you a while back. In my testing it avoids about 10% of the database calls when measured against a full crawl of a sitemap. You might want to consider it for the old theme engine branch. If you do want to include it for theme engine 1.0, I can also do a like PR for theme engine 2.0. |
JeffPyeBrook
force-pushed
the
dont-make-variations-calls-when-no-variations
branch
from
e469dc0 to
2839078
Compare
JustinSainton
force-pushed
the
master
branch
from
9868144 to
a97791b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check to see if variations are defined and used, when they are not defined and used don't make calls through WordPress for variation terms unless working inside the admin area. Avoids lots of small empty queries.
Add checks to variation class to avoid walking off the end of internal arrays