Skip to content

Fix 'wpsc_edit_product_variations' when editing variations ... #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dexmaster wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix 'wpsc_edit_product_variations' when editing variations ... #1779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions wpsc-admin/includes/product-functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,16 @@ function wpsc_determine_variation_price( $variation_id, $term_ids = false ) {
function wpsc_edit_product_variations($product_id, $post_data) {
global $user_ID;

if ( empty( $product_id ) ) {
if ( isset( $_REQUEST["product_id"] ) ) {
$product_id = $_REQUEST["product_id"];
} elseif ( isset( $_REQUEST["post_ID"] ) ) {
$product_id = $_REQUEST["post_ID"];
} else {
return;
}
}

$parent = get_post_field( 'post_parent', $product_id );

if( ! empty( $parent ) )
Expand Down Expand Up @@ -625,13 +635,11 @@ function wpsc_edit_product_variations($product_id, $post_data) {

wp_set_object_terms($product_id, $variation_sets_and_values, 'wpsc-variation');

$parent_id = $_REQUEST['product_id'];

$child_product_template = array(
'post_author' => $user_ID,
'post_content' => get_post_field( 'post_content', $parent_id, 'raw' ),
'post_excerpt' => get_post_field( 'post_excerpt', $parent_id, 'raw' ),
'post_title' => get_post_field( 'post_title', $parent_id, 'raw' ),
'post_content' => get_post_field( 'post_content', $product_id, 'raw' ),
'post_excerpt' => get_post_field( 'post_excerpt', $product_id, 'raw' ),
'post_title' => get_post_field( 'post_title', $product_id, 'raw' ),
'post_status' => 'inherit',
'post_type' => "wpsc-product",
'post_parent' => $product_id
Expand Down Expand Up @@ -733,19 +741,11 @@ function wpsc_edit_product_variations($product_id, $post_data) {
$term_ids_to_delete = array_diff($currently_associated_vars, $posted_terms);
}

if(isset($_REQUEST["post_ID"])) {
$post_id = $_REQUEST["post_ID"];
} elseif(isset($_REQUEST["product_id"])) {
$post_id = $_REQUEST["product_id"];
} else {
return;
}

if(!empty($term_ids_to_delete) && (isset($_REQUEST["product_id"]) || isset($post_id))) {
if(!empty($term_ids_to_delete) && (isset($product_id))) {
$post_ids_to_delete = array();

// Whatever remains, find child products of current product with that term, in the variation taxonomy, and delete
$post_ids_to_delete = wpsc_get_child_object_in_terms_var($_REQUEST["product_id"], $term_ids_to_delete, 'wpsc-variation');
$post_ids_to_delete = wpsc_get_child_object_in_terms_var($product_id, $term_ids_to_delete, 'wpsc-variation');

if(is_array($post_ids_to_delete) && !empty($post_ids_to_delete)) {
foreach($post_ids_to_delete as $object_ids) {
Expand All @@ -756,7 +756,7 @@ function wpsc_edit_product_variations($product_id, $post_data) {
}
}
$current_children = get_posts(array(
'post_parent' => $post_id,
'post_parent' => $product_id,
'post_type' => 'wpsc-product',
'post_status' => 'all',
'numberposts' => -1
Expand All @@ -774,7 +774,7 @@ function wpsc_edit_product_variations($product_id, $post_data) {
}
}
}
_wpsc_refresh_parent_product_terms( $parent_id );
_wpsc_refresh_parent_product_terms( $product_id );

}

Expand Down