fix: use term name for label instead of taxonomy slug in product attribtes. #936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to how variation attributes are handled and resolved in the WooCommerce GraphQL integration. The key changes include adding a
label
field to variation attributes and simplifying the resolution logic for thelabel
field.Enhancements to variation attribute handling:
includes/data/connection/class-variation-attribute-connection-resolver.php
: Added a newlabel
field to the variation attributes data array. This field is populated with the attribute's value or term name, depending on the context.includes/type/object/class-variation-attribute-type.php
: Simplified the resolver for thelabel
field in the GraphQL schema. The resolver now directly returns thelabel
field from the source if it exists, ornull
otherwise.What does this implement/fix? Explain your changes.When asking for the "LABEL" of a term in product attributes, we are getting the taxonomy slug.
BEFORE

Notice how we are getting
color
as the label ofgreen
.AFTER

Notice how we are getting
Green
as the label ofgreen
as it should be.