-
Notifications
You must be signed in to change notification settings - Fork 56
Clarify that Enable Desktop Support switch is CPP only #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2027
Are you sure you want to change the base?
Conversation
|
As the 2026.1.1 release is out, we're not going to make any changes to the gradle templates for 2026. Please change this to target the 2027 branch. |
done, just fixing conflicts |
Add a message for Manage Vendor Libraries Partially addresses wpilibsuite/2026Beta#1
Include vendordeps and build.gradle and full source directory to make it easier to restore from roboRIO jar. Fixes wpilibsuite/GradleRIO#713
a8167cd to
8ddad19
Compare
|
ok, i've somehow deleted all of my own commits during what was supposed to be a rebase. that's what i get for using |
ah, I pushed from a detached HEAD, and not a branch. At least it makes everything easy to restore :) |
|
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
| resetBaseDropdown(); | ||
| } else { | ||
| validateStep2(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd strongly prefer to just disable the checkbox and add a tooltip on hover to let the user know it's only necessary for C++ projects. Resetting like this is a bad user experience.
| @@ -1,5 +1,6 @@ | |||
| 'use strict'; | |||
|
|
|||
| import { getDesktopEnabled } from '../../utilities'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
Closes #800