Skip to content

Conversation

@cswilson252
Copy link

Closes #800

@sciencewhiz
Copy link
Contributor

As the 2026.1.1 release is out, we're not going to make any changes to the gradle templates for 2026. Please change this to target the 2027 branch.

@cswilson252 cswilson252 changed the base branch from main to 2027 January 11, 2026 04:24
@cswilson252
Copy link
Author

As the 2026.1.1 release is out, we're not going to make any changes to the gradle templates for 2026. Please change this to target the 2027 branch.

done, just fixing conflicts

@cswilson252 cswilson252 force-pushed the enableDesktopJavaRomi branch from a8167cd to 8ddad19 Compare January 11, 2026 04:42
@cswilson252
Copy link
Author

ok, i've somehow deleted all of my own commits during what was supposed to be a rebase. that's what i get for using git push --force. I'll redo this from a clean branch state

@cswilson252
Copy link
Author

ok, i've somehow deleted all of my own commits during what was supposed to be a rebase. that's what i get for using git push --force. I'll redo this from a clean branch state

ah, I pushed from a detached HEAD, and not a branch. At least it makes everything easy to restore :)

@cswilson252 cswilson252 marked this pull request as draft January 11, 2026 04:48
@cswilson252 cswilson252 marked this pull request as ready for review January 11, 2026 04:57
@cswilson252
Copy link
Author

done!

@cswilson252 cswilson252 requested a review from rzblue January 11, 2026 19:40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

resetBaseDropdown();
} else {
validateStep2();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd strongly prefer to just disable the checkbox and add a tooltip on hover to let the user know it's only necessary for C++ projects. Resetting like this is a bad user experience.

@@ -1,5 +1,6 @@
'use strict';

import { getDesktopEnabled } from '../../utilities';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Enable Desktop Support switch for Java, Romi, XRP

4 participants