Assembler: Impl tokenizer #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
Bennett-Petzold
approved these changes
Dec 27, 2024
Collaborator
Bennett-Petzold
left a comment
Bennett-Petzold
left a comment
There was a problem hiding this comment.
MSRV should be bumped to 1.80 to use stdlib instead of once cell, as mentioned. But that does not effect functionality, so this PR is good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the tokenizer stage of the assembler, which can be fed a line and will return a vector of tokens it was able to create from the line.
Known issues