Cleanup and enhancements #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt at fixing: #18
Owner
|
@teamcons Is this ready to be reviewed? |
Contributor
Author
|
Yes |
This was referenced Jun 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the app consider its new saving target only if it can actually load and save to it without fail.
Move some functions into an Utils. For two methods it may not be super interesting, but then Application can be more focused, and we can navigate more efficiently. And if for any reason more are needed, its there
(note: if that makes the app a bit too complex for your taste i can roll it back, no sweat)
Space things out a bit more like eOS does it
Hover on the headerbar to see the file location
when saving an unsaved file to a new location, automagically add a .txt
Slate can be set as default text editor, fixes FR: Set as default text editor #14
Avoid nuking files that cant be read Bug: Slate nukes files it cant read #18