fix: getChatById when sending @ number.#1919
Open
Saifallak wants to merge 10 commits intowppconnect-team:mainfrom
Open
fix: getChatById when sending @ number.#1919Saifallak wants to merge 10 commits intowppconnect-team:mainfrom
Saifallak wants to merge 10 commits intowppconnect-team:mainfrom
Conversation
Contributor
Author
|
@icleitoncosta can you check this? |
Collaborator
|
Hey @Saifallak , do you can fix lint errors? |
Contributor
Author
just now noticed your comment, fixed lints, and updated the code to the latest main. |
Contributor
Author
|
can you check why build is failing? @icleitoncosta any ideas? |
Contributor
|
This change is a breaking change, current implementation that do not send The best way to do it is just split on That way we can support current numbers and also |
manfe
requested changes
Nov 11, 2025
Contributor
manfe
left a comment
manfe
left a comment
There was a problem hiding this comment.
This is my suggestion to keep backwards compatibility, while supporting @c.us or @g.us
| */ | ||
| const { phone } = req.params; | ||
| const { isGroup } = req.query; | ||
| const { isGroup = false } = req.query; |
Contributor
There was a problem hiding this comment.
Suggested change
| const { isGroup = false } = req.query; | |
| const normalizedPN = phone?.split('@')?.[0] | |
| const { isGroup = false } = req.query; |
Comment on lines
+391
to
+392
| for (const contato of contactToArray(phone as string, isGroup as boolean)) { | ||
| result = await req.client.getChatById(contato); |
Contributor
There was a problem hiding this comment.
Suggested change
| for (const contato of contactToArray(phone as string, isGroup as boolean)) { | |
| result = await req.client.getChatById(contato); | |
| if (isGroup) { | |
| result = await req.client.getChatById(`${normalizedPN}@g.us`); | |
| } else { | |
| result = await req.client.getChatById(`${normalizedPN}@c.us`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.