Skip to content

Refactor - #9

Merged
wraithgar merged 8 commits into
mainfrom
gar/tests
Feb 26, 2026
Merged

Refactor#9
wraithgar merged 8 commits into
mainfrom
gar/tests

Conversation

@wraithgar

@wraithgar wraithgar commented Feb 26, 2026

Copy link
Copy Markdown
Owner

Benchmark of this vs original vs existing published version of this package, using a happy path promise with no retries:

$ node bench.js
original x 1,252,556 ops/sec ±0.34% (88 runs sampled)
ours - published x 1,324,869 ops/sec ±0.27% (88 runs sampled)
ours - refactored x 1,922,106 ops/sec ±0.34% (91 runs sampled)
Fastest is ours - refactored

owlstronaut
owlstronaut approved these changes Feb 26, 2026
View reviewed changes
Comment thread lib/index.d.ts Outdated
Comment thread test/retry.js Outdated
Comment thread lib/index.js Outdated
@wraithgar
fix: clean up type for removed params
18f33a4 
This was code in `retry` that was not reachable from the promise-retry interface
@wraithgar
wraithgar merged commit 6035d76 into main Feb 26, 2026
1 check passed
@wraithgar
wraithgar deleted the gar/tests branch February 26, 2026 21:28
@wraithgar wraithgar mentioned this pull request Feb 26, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@owlstronaut owlstronaut owlstronaut approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wraithgar @owlstronaut