Skip to content

Add initial content for visiting Berlin page and update TODOs #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 4, 2025
Merged

Add initial content for visiting Berlin page and update TODOs #2389

merged 6 commits into from
Jul 4, 2025

Conversation

@dariaavv
Copy link
Contributor

@dariaavv dariaavv commented Jun 15, 2025 •
edited by github-actions bot
Loading

  • Added frontmatter (commented out with added TODO -- images are missing)
  • Added section headers based on Portland 2025 visiting.md file

📚 Documentation preview 📚: https://writethedocs-www--2389.org.readthedocs.build/

plaindocs
plaindocs reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@plaindocs plaindocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @dariaavv

Let's keep the PR open, and fill in contents with suggested changes or PRs to this branch, whatever works until we've got enough of it to be useful.

docs/conf/berlin/2025/visiting.md Outdated
Comment on lines 3 to 5
# TODO: add images to _static/conf/images/headers/ for Berlin. Refer to docs\_data\berlin-2025-config.yaml for variables
# banner: _static/conf/images/headers/hike.png
# og:image: _static/conf/images/headers/{{shortcode}}-{{year}}-opengraph.jpg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's the first conf we have no Berlin pics, we could use some from the last in person event in prague from 2019.

@plaindocs
Copy link
Contributor

oh woah! Go @sroks !

plaindocs
plaindocs reviewed Jun 24, 2025
View reviewed changes
plaindocs
plaindocs approved these changes Jun 29, 2025
View reviewed changes
Copy link
Contributor

@plaindocs plaindocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can pretty much merge this? What do folks think?

@mxsasha mxsasha force-pushed the berlin-25-visiting branch from 6beada2 to 900ee47 Compare July 4, 2025 12:43
@mxsasha
Copy link
Contributor

mxsasha commented Jul 4, 2025

Seems like that spelling ignore isn't working yet though.

plaindocs
plaindocs reviewed Jul 4, 2025
View reviewed changes
@plaindocs
Copy link
Contributor

Let's try thi

plaindocs
plaindocs reviewed Jul 4, 2025
View reviewed changes
@plaindocs plaindocs marked this pull request as ready for review July 4, 2025 13:20
@plaindocs plaindocs merged commit 2b43563 into writethedocs:main Jul 4, 2025
6 checks passed
@plaindocs
Copy link
Contributor

Thanks @dariaavv @sroks !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plaindocs plaindocs plaindocs approved these changes

@mxsasha mxsasha mxsasha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dariaavv @plaindocs @mxsasha @sroks