Add support for 'contain' mode in password username validation policy #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
...ernance/src/main/java/org/wso2/carbon/identity/governance/IdentityGovernanceServiceImpl.java
Show resolved
Hide resolved
...ernance/src/main/java/org/wso2/carbon/identity/governance/IdentityGovernanceServiceImpl.java
Show resolved
Hide resolved
...n/java/org/wso2/carbon/identity/password/policy/handler/PasswordPolicyValidationHandler.java
Show resolved
Hide resolved
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 | NO | This log seems unnecessary and would create noise. |
| #### Log Improvement Suggestion No: 2 | NO | This log seems unnecessary and would create noise. |
| #### Log Improvement Suggestion No: 3 | NO | This log seems unnecessary and would create noise. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1069 +/- ##
============================================
- Coverage 54.26% 53.97% -0.30%
- Complexity 3101 3125 +24
============================================
Files 315 315
Lines 21330 21585 +255
Branches 4073 4167 +94
============================================
+ Hits 11575 11650 +75
- Misses 8273 8430 +157
- Partials 1482 1505 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
$subject
[Please hold merging as this handler is deprecated]
This policy can be enabled by the following config:
Related: wso2/carbon-identity-framework#7570