Fixm/multi email separate #1078
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
Comment on lines
122
to
+123
| boolean supportMultipleMobileNumbers = | ||
| Utils.isMultiEmailsAndMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | ||
| Utils.isMultiMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| boolean supportMultipleMobileNumbers = | |
| Utils.isMultiEmailsAndMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | |
| Utils.isMultiMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | |
| boolean supportMultipleMobileNumbers = | |
| Utils.isMultiMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | |
| if (log.isDebugEnabled()) { | |
| log.debug("Multiple mobile numbers support is " + (supportMultipleMobileNumbers ? "enabled" : "disabled") + " for user: " + user.getLoggableUserId()); | |
| } |
Comment on lines
344
to
+345
| boolean supportMultipleMobileNumbers = | ||
| Utils.isMultiEmailsAndMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | ||
| Utils.isMultiMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 2
Suggested change
| boolean supportMultipleMobileNumbers = | |
| Utils.isMultiEmailsAndMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | |
| Utils.isMultiMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | |
| boolean supportMultipleMobileNumbers = | |
| Utils.isMultiMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | |
| if (log.isDebugEnabled()) { | |
| log.debug("Checking multiple mobile numbers support for claim update. Support enabled: " + supportMultipleMobileNumbers); | |
| } |
Comment on lines
124
to
+125
| boolean supportMultipleEmails = | ||
| Utils.isMultiEmailsAndMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | ||
| Utils.isMultiEmailAddressesPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 3
Suggested change
| boolean supportMultipleEmails = | |
| Utils.isMultiEmailsAndMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | |
| Utils.isMultiEmailAddressesPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | |
| boolean supportMultipleEmails = | |
| Utils.isMultiEmailAddressesPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | |
| if (log.isDebugEnabled()) { | |
| log.debug("Multiple email addresses support: " + supportMultipleEmails + " for user: " + user.getLoggableUserId()); | |
| } |
Comment on lines
554
to
+555
| boolean supportMultipleEmails = | ||
| Utils.isMultiEmailsAndMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | ||
| Utils.isMultiEmailAddressesPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 4
Suggested change
| boolean supportMultipleEmails = | |
| Utils.isMultiEmailsAndMobileNumbersPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | |
| Utils.isMultiEmailAddressesPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | |
| boolean supportMultipleEmails = | |
| Utils.isMultiEmailAddressesPerUserEnabled(user.getTenantDomain(), user.getUserStoreDomain()); | |
| if (log.isDebugEnabled()) { | |
| log.debug("Checking multiple email support for email update. Support enabled: " + supportMultipleEmails); | |
| } |
| IdentityGovernanceService identityGovernanceService = IdentityRecoveryServiceDataHolder.getInstance() | ||
| .getIdentityGovernanceService(); | ||
| connectorConfigs = identityGovernanceService.getConfiguration(new String[]{key,}, tenantDomain); | ||
| connectorConfigs = identityGovernanceService.getConfiguration(new String[]{key}, tenantDomain); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 5
Suggested change
| connectorConfigs = identityGovernanceService.getConfiguration(new String[]{key}, tenantDomain); | |
| connectorConfigs = identityGovernanceService.getConfiguration(new String[]{key}, tenantDomain); | |
| if (log.isDebugEnabled()) { | |
| log.debug("Retrieved sign up configuration for key: " + key + " in tenant: " + tenantDomain); | |
| } |
Comment on lines
+1564
to
+1566
| isEmailVerificationOnUpdateEnabled = isEmailVerificationOnUpdateEnabled(tenantDomain); | ||
| } catch (IdentityEventException e) { | ||
| log.error("Error while retrieving email verification on update config.", e); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 6
Suggested change
| isEmailVerificationOnUpdateEnabled = isEmailVerificationOnUpdateEnabled(tenantDomain); | |
| } catch (IdentityEventException e) { | |
| log.error("Error while retrieving email verification on update config.", e); | |
| } catch (IdentityEventException e) { | |
| log.error("Error while retrieving email verification on update config for tenant: " + tenantDomain); | |
| return false; |
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1078 +/- ##
============================================
+ Coverage 54.34% 54.36% +0.01%
- Complexity 3134 3145 +11
============================================
Files 316 316
Lines 21485 21524 +39
Branches 4103 4108 +5
============================================
+ Hits 11677 11701 +24
- Misses 8318 8329 +11
- Partials 1490 1494 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
[List all changes you want to add here. If you fixed an issue, please
add a reference to that issue as well.]
When should this PR be merged
[Please describe any preconditions that need to be addressed before we
can merge this pull request.]
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation