Skip to content

Conversation

@sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Aug 1, 2025

Purpose

$subject

This PR fixes the following flow.

User approval workflow is configured in the sub-org level. The User Smith (ID2) has the access to approve the user management operations. The Smith (ID2) is a shared user from root organization.

When Smith login to console and switch to the sub-organization, the authenticated user-id is ID1 which related to the user-id in the parent org. When he check for the pending approvals, there are no approvals as the approvals are configured for the user ID2 (which is the shared user-id).

Hence the proposed change of this PR is required to resolve the shared user-id.

Related Issues

Screenshot 2025-08-08 at 17 35 31

Copilot AI review requested due to automatic review settings August 1, 2025 03:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for workflow approval functionality for shared users in multi-organization environments. It integrates with the organization management component to handle user sharing across organizations and ensures workflow approvals work correctly for shared users.

  • Added dependency on organization management user sharing component
  • Modified role ID retrieval logic to handle shared users by resolving their associated user IDs in the target organization
  • Cleaned up unused BundleContext references in the service data holder

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
pom.xml Added organization management dependency and updated version ranges
WorkflowEngineServiceDataHolder.java Removed unused BundleContext field and methods
ApprovalTaskServiceImpl.java Added shared user support logic in role ID retrieval
components/.../pom.xml Added dependency and import package configurations
Comments suppressed due to low confidence (1)

pom.xml:224

  • Missing closing tag for the org.wso2.identity.organization.mgt.import.version.range property. The property definition spans multiple lines incorrectly.
        <org.wso2.identity.organization.mgt.import.version.range>[1.0.0,3.0.0)

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/16829622340

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/16829622340
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/16829622340

sadilchamishka and others added 2 commits August 8, 2025 18:31
@sadilchamishka sadilchamishka merged commit 3751c89 into wso2-extensions:main Aug 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants