Delete pending approval tasks when workflow request is deleted #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to delete pending approval tasks when a workflow request is deleted, ensuring proper cleanup of related resources. The implementation adds a new method to selectively delete only tasks in pending states (READY, RESERVED, BLOCKED) rather than all approval tasks.
- Adds a new SQL query to delete pending approval tasks with specific status filtering
- Implements the deletion logic through the DAO, service implementation, and interface layers
- Provides proper error handling and parameter validation for the new functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| WorkflowEngineConstants.java | Adds SQL query constant for deleting pending approval tasks with status filter |
| ApprovalTaskDAOImpl.java | Implements the database operation to delete pending approval tasks |
| ApprovalTaskDAO.java | Defines the interface method for deleting pending approval tasks |
| ApprovalTaskServiceImpl.java | Implements the service layer method with validation |
| ApprovalTaskService.java | Declares the service interface method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...kflow.engine/src/main/java/org/wso2/carbon/identity/workflow/engine/ApprovalTaskService.java
Outdated
Show resolved
Hide resolved
...ine/src/main/java/org/wso2/carbon/identity/workflow/engine/internal/dao/ApprovalTaskDAO.java
Outdated
Show resolved
Hide resolved
…ava/org/wso2/carbon/identity/workflow/engine/internal/dao/ApprovalTaskDAO.java Co-authored-by: Copilot <[email protected]>
…ava/org/wso2/carbon/identity/workflow/engine/ApprovalTaskService.java Co-authored-by: Copilot <[email protected]>
Contributor
Author
|
Integration Test - https://github.com/sadilchamishka/product-is/actions/runs/17057346775 |
Malith-19
approved these changes
Aug 19, 2025
ashensw
approved these changes
Aug 19, 2025
Malith-19
pushed a commit
to Malith-19/identity-workflow
that referenced
this pull request
Sep 4, 2025
…release v1.0.11
Malith-19
pushed a commit
to Malith-19/identity-workflow
that referenced
this pull request
Sep 4, 2025
…for next development iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Related Issues