Skip to content

Conversation

@Tharsanan1
Copy link
Contributor

@Tharsanan1 Tharsanan1 commented Feb 11, 2026

Summary

  • update gateway/it/Makefile ensure-test-tags flow
  • retag :test from :<VERSION> when a version image is available
  • keep existing :test image when version images are unavailable
  • fail only when neither :<VERSION> nor :test image exists

Why

This avoids stale :test tags when new version images exist, while keeping local test runs working when only :test is present.

Summary by CodeRabbit

  • Chores
    • Updated internal build infrastructure to improve Docker image tagging logic with enhanced fallback mechanisms and messaging for the test environment.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

Walkthrough

The ensure-test-tags Makefile target was restructured to use a short-circuit conditional chain instead of checking all paths before reporting errors. The new logic prioritizes image versions in order: exact version match, base version match, existing test image, or failure.

Changes

Cohort / File(s) Summary
Makefile Image Tagging Logic
gateway/it/Makefile
Restructured ensure-test-tags target to use short-circuit chain for Docker image tagging. Replaced all-paths-then-error approach with explicit priority-based conditionals: exact version → base version → existing test image → error. Added echo messages for each success path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A Makefile's tale, short-circuited with care,
Image tags now flowing with logical flair,
Versioned images first, then the base takes its turn,
Fallbacks in order, each lesson we learn!
No more all-paths checked—just priority's dance!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request provides a summary with why, what, and how information, but lacks required template sections like Purpose, Goals, Approach, User stories, Documentation, Automation tests, Security checks, Samples, Related PRs, and Test environment. Complete the pull request description using the provided template, including all required sections such as Purpose, Goals, Approach, Documentation, Automation tests, Security checks, and Test environment details.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the test tag refresh logic to only occur when version images are available.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Tharsanan1 Tharsanan1 changed the title it: refresh :test tags only when version images exist Refresh test tags only when version images exist Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant