Skip to content

Fix global policy parameter retrieval when editing policies #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix global policy parameter retrieval when editing policies #1197

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1daaa8
Initial plan
Copilot Oct 18, 2025
e6d4000
Add warning message for missing policy parameters in edit mode
Copilot Oct 18, 2025
2deb0ef
Fix linting issues in warning message implementation
Copilot Oct 18, 2025
53a27a7
Fix policy parameter retrieval by adding fallback lookup strategy
Copilot Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions ...onents/GlobalPolicies/Policies/GlobalSpecificComponents/PolicyConfigurationEditDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,26 @@ const PolicyConfigurationEditDrawer: FC<PolicyConfigurationEditDrawerProps> = ({
}, [policyObj]);

/**
* Find the editing operation flow policy
* Find the editing operation flow policy.
* First try to find by uuid, then fall back to matching by policy identifiers.
*/
const operationFlowPolicy = (globalLevelPolicies)[
currentFlow
].find((policy: any) => policy.uuid === policyObj?.uniqueKey);
let operationFlowPolicy = undefined;
if (globalLevelPolicies && globalLevelPolicies[currentFlow]) {
// Try to find by uuid first
operationFlowPolicy = globalLevelPolicies[currentFlow].find(
(policy: any) => policy.uuid === policyObj?.uniqueKey
);

// If not found by uuid, try to find by policy identifiers as fallback
if (!operationFlowPolicy && policyObj) {
operationFlowPolicy = globalLevelPolicies[currentFlow].find(
(policy: any) =>
policy.policyId === policyObj.id &&
policy.policyName === policyObj.name &&
policy.policyVersion === policyObj.version
);
}
}

const globalPolicy: GlobalPolicy = operationFlowPolicy || {
policyName: policyObj?.name,
Expand Down