Add max return for Traffic Manager multivalue profile

[SazniMohamed]

Change Description

• New Features
  • Added a configurable parameter for Traffic Manager profiles to control the maximum number of endpoints returned in DNS queries (default: 8).
  • Added a new firewall output that exposes a mapping of NAT rule keys to destination and translated IP address pairs for easier address lookup.

[coderabbitai]

Walkthrough

Added a new max_return input and wired it into the azurerm_traffic_manager_profile resource; also introduced a new output firewall_nat_rule_address_mapping that maps NAT rule keys to destination/translated addresses.

Changes

Cohort / File(s)	Summary
Traffic Manager Profile modules/azurerm/Traffic-Manager-Profile/traffic_manager_profile.tf, modules/azurerm/Traffic-Manager-Profile/variables.tf	Added max_return argument to azurerm_traffic_manager_profile and introduced variable "max_return" (type = number, default = 8) to control the maximum number of endpoints returned in DNS queries.
Firewall NAT Outputs modules/azurerm/Firewall-Multiple-PIP/output.tf	Added firewall_nat_rule_address_mapping output that builds a map from NAT rule keys to objects containing destination_address (from azurerm_public_ip.firewall_public_ip[...] .ip_address) and translated_address (from the NAT rule's private_ip_address).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Files to spot-check:
  • modules/azurerm/Traffic-Manager-Profile/traffic_manager_profile.tf — ensure max_return is placed in the correct block and type matches provider expectations.
  • modules/azurerm/Traffic-Manager-Profile/variables.tf — confirm variable docs and default are appropriate.
  • modules/azurerm/Firewall-Multiple-PIP/output.tf — verify the mapping keys align with NAT rule collection and referenced resources exist.

Poem

I nibble code beneath the moon,
A new max_return sings a tune,
NAT maps stitched from hop to hop,
Eight by default — then stop, then stop! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description lacks required sections specified in the repository template, including Purpose, Goals, Approach, User stories, Release note, Documentation, and others.	Complete the pull request description using the repository template. Fill in all required sections including Purpose with issue links, Goals, Approach, User stories, Release note, and Documentation impact. The minimal description provided does not follow the established template structure.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title 'Add max return for Traffic Manager multivalue profile' directly aligns with the main changes: adding a max_return argument to the azurerm_traffic_manager_profile resource and supporting variable.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}