Skip to content

Implement nested error message handling for schema validation #13045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement nested error message handling for schema validation #13045

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15a0833
Implement nested error message handling for schema validation
Jithmi004 Mar 7, 2025
241c1a1
Format the code
Jithmi004 Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions ...teway/src/main/java/org/wso2/carbon/apimgt/gateway/handlers/security/SchemaValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,11 @@ public boolean handleRequest(MessageContext messageContext) {
if (validationReport.hasErrors()) {
StringBuilder finalMessage = new StringBuilder();
for (ValidationReport.Message message : validationReport.getMessages()) {
finalMessage.append(message.getMessage()).append(", ");
finalMessage.append(getErrorMessage(message)).append(", ");
}
// Remove the last comma and space, if present
if (finalMessage.length() > 0) {
finalMessage.setLength(finalMessage.length() - 2);
}
String errMessage = "Schema validation failed in the Request: ";
logger.error(errMessage);
Expand All @@ -101,7 +105,11 @@ public boolean handleResponse(MessageContext messageContext) {
if (validationReport.hasErrors()) {
StringBuilder finalMessage = new StringBuilder();
for (ValidationReport.Message message : validationReport.getMessages()) {
finalMessage.append(message.getMessage()).append(", ");
finalMessage.append(getErrorMessage(message)).append(", ");
}
// Remove the last comma and space, if present
if (finalMessage.length() > 0) {
finalMessage.setLength(finalMessage.length() - 2);
}
String errMessage = "Schema validation failed in the Response: ";
logger.error(errMessage);
Expand All @@ -110,4 +118,16 @@ public boolean handleResponse(MessageContext messageContext) {
}
return true;
}

private String getErrorMessage(ValidationReport.Message message){
if(message.getNestedMessages().isEmpty()){
return message.getMessage();
}
StringBuilder combinedMessages = new StringBuilder();
combinedMessages.append(message.getMessage());
for (ValidationReport.Message nestedMessage : message.getNestedMessages()) {
combinedMessages.append(", ").append(getErrorMessage(nestedMessage));
}
return combinedMessages.toString().trim();
}
}
Loading