Fix null pointer exception when the tenant is invalid

[Jithmi004]

Purpose

When trying to change the API Provider through admin portal, if an invalid tenant name is given as input, (john@ a bc.com -> space within the tenant domain or [email protected] where test.com does not exist) an NPE is thrown. This PR fixes that issue.

Fixes: wso2/api-manager#3735

Implementation Details

If the tenant is invalid, the tenantId becomes -1. If that happens, an APIManagementException is now thrown with INVALID_TENANT as the ExceptionCode.

[coderabbitai]

📝 Walkthrough

"""

Walkthrough

The changes introduce a new condition in the isUserExist() method within the API utility class. The method now checks if the tenant ID is -1, indicating that the tenant does not exist, and throws an APIManagementException with the INVALID_TENANT error code if the validation fails. The rest of the method continues to check user existence via the user store manager if the tenant ID is valid.

Changes

File(s)	Change Summary
components/.../APIUtil.java	Updated isUserExist(String username) method to validate tenant ID and throw APIManagementException with INVALID_TENANT if tenant ID is -1.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant APIUtil
    Caller->>APIUtil: call isUserExist(username)
    APIUtil->>APIUtil: Retrieve tenant ID
    alt Tenant ID equals -1
        APIUtil-->>Caller: throw APIManagementException (INVALID_TENANT)
    else Tenant exists
        APIUtil->>UserStoreManager: check user existence
        UserStoreManager-->>APIUtil: return existence result
        APIUtil-->>Caller: return user existence result
    end

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Handle invalid tenant exceptions to prevent backend NullPointerException (#3735)	✅
Ensure provider name formatting and edit flow issues do not cause erroneous behavior (#3735)	❌	Provider formatting and edit behavior changes are not modified.

Suggested reviewers

• tgtshanika
• chamilaadhi
• tharindu1st
• dushaniw
  """

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.31.1)

components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/utils/APIUtil.java

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20d15b2 and c1fcbf0.

📒 Files selected for processing (1)

• components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/utils/APIUtil.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/utils/APIUtil.java

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: run-benchmark-test
• GitHub Check: build-product (4, group4)
• GitHub Check: build-product (3, group3)
• GitHub Check: build-product (2, group2)
• GitHub Check: build-product (1, group1)
• GitHub Check: build-carbon
• GitHub Check: build-carbon

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.