Make transport cleanup configurable #13064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PasanT9
requested review from
tharindu1st,
AnuGayan,
chamilaadhi,
Arshardh,
dushaniw and
tgtshanika
as code owners
📝 WalkthroughWalkthroughThis pull request adds a new constant to the API management gateway constants and modifies the Changes
Sequence Diagram(s)sequenceDiagram
participant BA as BasicAuthCredentialValidator
participant SP as System Properties
participant SC as ServiceClient Options
BA->>SP: Get property "autoTransportOperationCleanUp"
alt Property exists
BA->>SC: Set auto cleanup option based on property value
else
BA->>SC: Proceed with default configuration
end
Assessment against linked issues
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/apimgt/org.wso2.carbon.apimgt.gateway/src/main/java/org/wso2/carbon/apimgt/gateway/handlers/security/basicauth/BasicAuthCredentialValidator.java (1)
98-102: Optimize the system property check by retrieving the value once.The code makes two separate calls to retrieve the same system property. This is inefficient and could be optimized.
-if (System.getProperty(APIMgtGatewayConstants.AUTO_TRANSPORT_OPERATION_CLEANUP) != null) { - options.setProperty(ServiceClient.AUTO_OPERATION_CLEANUP, - Boolean.parseBoolean( - System.getProperty(APIMgtGatewayConstants.AUTO_TRANSPORT_OPERATION_CLEANUP))); +String autoCleanupPropertyValue = System.getProperty(APIMgtGatewayConstants.AUTO_TRANSPORT_OPERATION_CLEANUP); +if (autoCleanupPropertyValue != null) { + boolean autoCleanup = Boolean.parseBoolean(autoCleanupPropertyValue); + options.setProperty(ServiceClient.AUTO_OPERATION_CLEANUP, autoCleanup); + if (log.isDebugEnabled()) { + log.debug("Setting ServiceClient.AUTO_OPERATION_CLEANUP to " + autoCleanup); + } }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
components/apimgt/org.wso2.carbon.apimgt.gateway/src/main/java/org/wso2/carbon/apimgt/gateway/APIMgtGatewayConstants.java(1 hunks)components/apimgt/org.wso2.carbon.apimgt.gateway/src/main/java/org/wso2/carbon/apimgt/gateway/handlers/security/basicauth/BasicAuthCredentialValidator.java(2 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
components/apimgt/org.wso2.carbon.apimgt.gateway/src/main/java/org/wso2/carbon/apimgt/gateway/handlers/security/basicauth/BasicAuthCredentialValidator.java (1)
components/apimgt/org.wso2.carbon.apimgt.gateway/src/main/java/org/wso2/carbon/apimgt/gateway/APIMgtGatewayConstants.java (1)
APIMgtGatewayConstants(22-202)
🔇 Additional comments (1)
components/apimgt/org.wso2.carbon.apimgt.gateway/src/main/java/org/wso2/carbon/apimgt/gateway/APIMgtGatewayConstants.java (1)
183-183: Looks good - new constant for configurable transport cleanup.This constant introduces the system property that allows users to configure the auto-cleanup process for transport operations, aligning with the PR objective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: wso2/api-manager#3806
Make the auto-cleanup process configurable by introducing a system property,
autoTransportOperationCleanUp. You can control whether to enable the auto-cleanup process when starting the API-M. Setting this property to false will disable the auto-cleanup mechanism.ex. ./wso2server.sh -DautoTransportOperationCleanUp=false