Skip to content

convert swagger2.0 to openapi of internal api #13067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

tharindu1st
Copy link
Contributor

convert swagger2.0 to openapi of internal api

Copy link

coderabbitai bot commented Apr 3, 2025

📝 Walkthrough

Walkthrough

The pull request introduces two new files in the OpenAPI generator directory: one file specifying the generator version (4.3.1) and another containing a SHA-256 hash value for an API specification file. Additionally, the Maven build configuration in the pom.xml file has been updated. The previous configuration using the swagger2cxf-maven-plugin and the maven-war-plugin has been removed, and in its place, the openapi-generator-maven-plugin has been added with additional configuration options. The clean-up configuration now targets generated Java files in the src/gen/java directory.

Changes

File(s) Change Summary
components/.../.openapi-generator/VERSION
components/.../.openapi-generator/api.yaml.sha256
New files added: one specifying the OpenAPI generator version (4.3.1) and the other providing a SHA-256 hash for api.yaml.
components/.../pom.xml Updated Maven configuration: removed the swagger2cxf-maven-plugin and maven-war-plugin; added the openapi-generator-maven-plugin with extra parameters and reconfigured the maven-clean-plugin for cleaning generated sources.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer
    participant Maven as Maven Build
    participant OGG as OpenAPI Generator Plugin

    Dev ->> Maven: Trigger build
    Maven ->> OGG: Invoke openapi-generator-maven-plugin
    OGG -->> Maven: Generate server stubs from api.yaml
    Maven ->> Dev: Return build results
Loading

Suggested reviewers

  • tgtshanika
  • chamilaadhi
  • dushaniw
  • Arshardh
  • AnuGayan

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
components/apimgt/org.wso2.carbon.apimgt.internal.service/pom.xml (1)

136-168: OpenAPI Generator Plugin Configuration Review.
This block introduces the new openapi-generator-maven-plugin to generate server stubs from the OpenAPI specification. The parameters (such as inputSpec, language, and configOptions) are well configured for a JAX-RS/CXF CDI setup with bean validation enabled. One note: the <modelNameSuffix>DTO</modelNameSuffix> appears twice (once at line 158 and again at line 164). It is advisable to remove the duplicate to avoid any potential ambiguity. For example, you could remove the second occurrence as shown in the diff below.

-                                <modelNameSuffix>DTO</modelNameSuffix>
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3ac8150 and 06e5191.

⛔ Files ignored due to path filters (93)
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ApiLoggingConfigsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ApiPoliciesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ApisApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ApplicationKeyMappingsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ApplicationPoliciesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ApplicationsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/BlockApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/CorrelationConfigsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/EndpointCertificatesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/GaConfigApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/GatewayPolicyArtifactsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/GlobalPoliciesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/KeyTemplatesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/KeymanagersApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/LlmProvidersApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/NotifyApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/NotifyApiService.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/RetrieveApiArtifactsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/RevokedjwtApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/RuntimeArtifactsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/RuntimeMetadataApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ScopesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/SubscribeInternalApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/SubscriptionPoliciesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/SubscriptionsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/TransactionRecordsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/WebhooksSubscriptionsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/AIAPIQuotaLimitAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/AIAPIQuotaLimitDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/APIDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/APIListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/APILoggingConfigDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/APILoggingConfigListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApiPolicyAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApiPolicyConditionGroupDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApiPolicyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApiPolicyListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApplicationDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApplicationKeyMappingDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApplicationKeyMappingListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApplicationListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApplicationPolicyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApplicationPolicyListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/BandwidthLimitAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/BandwidthLimitDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/BlockConditionsDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/BurstLimitDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ConditionDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/CorrelationComponentDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/CorrelationComponentPropertyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/CorrelationComponentsListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/DeployedAPIRevisionDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/DeployedEnvInfoDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ErrorDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/EventCountLimitAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/EventCountLimitDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/GlobalPolicyAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/GlobalPolicyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/GlobalPolicyListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/GraphQLQueryDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/GroupIdDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/IPLevelDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/KeyManagerDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/LLMProviderDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/LLMProviderListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/OperationPolicyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/PaginationDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/PolicyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RequestCountLimitAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RequestCountLimitDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RevokeAPIKeyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RevokedEventsDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RevokedJWTConsumerKeyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RevokedJWTDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RevokedJWTSubjectEntityDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ScopeDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ScopesListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SubscriptionDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SubscriptionListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SubscriptionPolicyAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SubscriptionPolicyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SubscriptionPolicyListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SynapseArtifactDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SynapseArtifactListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SynapseAttributesDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ThrottleLimitBaseDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ThrottleLimitDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/TransactionRecordDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/URLMappingDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/UUIDListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/UnDeployedAPIRevisionDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/WebhooksSubscriptionDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/WebhooksSubscriptionsListDTO.java is excluded by !**/gen/**
📒 Files selected for processing (3)
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/.openapi-generator/VERSION (1 hunks)
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/.openapi-generator/api.yaml.sha256 (1 hunks)
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/pom.xml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: build-product (2, group2)
  • GitHub Check: build-product (4, group4)
  • GitHub Check: build-carbon
  • GitHub Check: build-product (3, group3)
  • GitHub Check: run-benchmark-test
  • GitHub Check: build-product (1, group1)
🔇 Additional comments (3)
components/apimgt/org.wso2.carbon.apimgt.internal.service/.openapi-generator/VERSION (1)

1-1: Version File Validity.
The file correctly specifies the version "4.3.1" for the OpenAPI generator. Please ensure that this version remains in sync with the configuration in the POM file for consistency.

components/apimgt/org.wso2.carbon.apimgt.internal.service/.openapi-generator/api.yaml.sha256 (1)

1-1: SHA-256 Hash Verification.
The file contains the expected SHA-256 hash value for the api.yaml file. Remember to update this hash if the API specification changes in the future.

components/apimgt/org.wso2.carbon.apimgt.internal.service/pom.xml (1)

123-133: Clean-Up Plugin Configuration Check.
The configuration for the maven-clean-plugin is correctly set up to clean up the generated Java sources in src/gen/java. Ensure that this clean-up aligns with your overall build lifecycle and does not inadvertently remove any required artifacts.

@tharindu1st tharindu1st force-pushed the tenantcy-db-removal branch from 06e5191 to e2d1f22 Compare April 3, 2025 13:40
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
components/apimgt/org.wso2.carbon.apimgt.internal.service/pom.xml (1)

136-168: OpenAPI Generator Plugin Configuration – Remove Duplicate Tag

The new openapi-generator-maven-plugin configuration looks well structured, with clear settings for the input specification, language, and code generation options. However, note that the <modelNameSuffix>DTO</modelNameSuffix> element appears twice (lines 158 and 164). Consider removing the duplicate to avoid any potential ambiguity in configuration.

Suggested change:

-                                <modelNameSuffix>DTO</modelNameSuffix>
...
-                                <modelNameSuffix>DTO</modelNameSuffix>

Keep only one instance of <modelNameSuffix>DTO</modelNameSuffix>.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 06e5191 and e2d1f22.

⛔ Files ignored due to path filters (93)
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ApiLoggingConfigsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ApiPoliciesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ApisApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ApplicationKeyMappingsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ApplicationPoliciesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ApplicationsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/BlockApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/CorrelationConfigsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/EndpointCertificatesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/GaConfigApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/GatewayPolicyArtifactsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/GlobalPoliciesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/KeyTemplatesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/KeymanagersApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/LlmProvidersApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/NotifyApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/NotifyApiService.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/RetrieveApiArtifactsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/RevokedjwtApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/RuntimeArtifactsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/RuntimeMetadataApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/ScopesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/SubscribeInternalApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/SubscriptionPoliciesApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/SubscriptionsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/TransactionRecordsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/WebhooksSubscriptionsApi.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/AIAPIQuotaLimitAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/AIAPIQuotaLimitDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/APIDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/APIListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/APILoggingConfigDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/APILoggingConfigListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApiPolicyAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApiPolicyConditionGroupDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApiPolicyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApiPolicyListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApplicationDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApplicationKeyMappingDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApplicationKeyMappingListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApplicationListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApplicationPolicyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ApplicationPolicyListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/BandwidthLimitAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/BandwidthLimitDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/BlockConditionsDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/BurstLimitDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ConditionDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/CorrelationComponentDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/CorrelationComponentPropertyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/CorrelationComponentsListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/DeployedAPIRevisionDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/DeployedEnvInfoDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ErrorDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/EventCountLimitAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/EventCountLimitDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/GlobalPolicyAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/GlobalPolicyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/GlobalPolicyListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/GraphQLQueryDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/GroupIdDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/IPLevelDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/KeyManagerDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/LLMProviderDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/LLMProviderListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/OperationPolicyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/PaginationDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/PolicyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RequestCountLimitAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RequestCountLimitDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RevokeAPIKeyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RevokedEventsDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RevokedJWTConsumerKeyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RevokedJWTDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/RevokedJWTSubjectEntityDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ScopeDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ScopesListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SubscriptionDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SubscriptionListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SubscriptionPolicyAllOfDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SubscriptionPolicyDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SubscriptionPolicyListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SynapseArtifactDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SynapseArtifactListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/SynapseAttributesDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ThrottleLimitBaseDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/ThrottleLimitDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/TransactionRecordDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/URLMappingDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/UUIDListDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/UnDeployedAPIRevisionDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/WebhooksSubscriptionDTO.java is excluded by !**/gen/**
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/src/gen/java/org/wso2/carbon/apimgt/internal/service/dto/WebhooksSubscriptionsListDTO.java is excluded by !**/gen/**
📒 Files selected for processing (3)
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/.openapi-generator/VERSION (1 hunks)
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/.openapi-generator/api.yaml.sha256 (1 hunks)
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/pom.xml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/.openapi-generator/VERSION
  • components/apimgt/org.wso2.carbon.apimgt.internal.service/.openapi-generator/api.yaml.sha256
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: build-product (2, group2)
  • GitHub Check: build-product (4, group4)
  • GitHub Check: build-product (1, group1)
  • GitHub Check: run-benchmark-test
  • GitHub Check: build-product (3, group3)
  • GitHub Check: build-carbon
🔇 Additional comments (3)
components/apimgt/org.wso2.carbon.apimgt.internal.service/pom.xml (3)

122-135: Clean Plugin Configuration Verification

The configuration for the maven-clean-plugin clearly specifies a fileset to clean all files under src/gen/java, which helps prevent stale generated sources from interfering with builds. Ensure that if additional generated directories are introduced in the future they are also included in this clean-up configuration.


169-187: Build Helper Plugin Configuration Approval

The addition of the build-helper-maven-plugin to add src/gen/java as a source folder is correctly configured. This ensures the generated sources are available during the build phase.


188-199: Jacoco Plugin Exclusion Patterns – Verify Exclusion Intent

The exclusion configuration for jacoco-maven-plugin lists <exclude>*</exclude> as the first pattern, which could unintentionally exclude all classes from coverage reports. Please verify that this is the intended behavior. If not, consider refining the exclusion patterns to target only specific packages or classes (e.g., generated DTOs and API/service implementations) rather than everything.

@tharindu1st tharindu1st merged commit 9766eed into wso2:master Apr 3, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants