-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commons validator to the gateway feature. #13069
Conversation
📝 WalkthroughWalkthroughThis pull request updates the API Gateway feature’s POM configuration to include the Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
features/apimgt/org.wso2.carbon.apimgt.rest.api.gateway.feature/pom.xml (1)
58-62
: Verify the Commons Validator Dependency Configuration.
The new dependency forcommons-validator
has been added correctly using the version placeholder${commons-validator.version}
. Please ensure that this property is defined in the parent POM or an appropriate properties section so that Maven can resolve the version during the build.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
features/apimgt/org.wso2.carbon.apimgt.rest.api.gateway.feature/pom.xml
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: build-product (3, group3)
- GitHub Check: build-product (1, group1)
- GitHub Check: build-product (2, group2)
- GitHub Check: run-benchmark-test
- GitHub Check: build-product (4, group4)
- GitHub Check: build-carbon
🔇 Additional comments (1)
features/apimgt/org.wso2.carbon.apimgt.rest.api.gateway.feature/pom.xml (1)
166-166
: Confirm Bundle Definition for Commons Validator.
The<bundleDef>
entry forcommons-validator
follows the existing convention, which is good. Please verify that including this bundle is necessary for your OSGi configuration or deployment requirements, and that the version placeholder will be replaced correctly at build time.
No description provided.