Update the queries to get all valid webhook subscriptions.

[Oshanath]

Related issue: wso2/api-manager#3809

Replace the cartesian products and the conditions with joins to fix the issue where the same result is returned multiple times.

Add a clause to include subscriptions with an expiry time of 0, since they never expire.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes refactor the SQL queries in the WebhooksSqlConstants class by replacing comma-separated joins with explicit JOIN syntax. Conditions previously listed in the WHERE clause have been moved into the JOIN conditions to clarify table relationships. Additionally, the expiry condition now checks for a value of 0, and an explicit casting for APPLICATION_ID has been added for PostgreSQL compatibility. There are no modifications to the exported or public entities.

Changes

File	Change Summary
components/apimgt/.../SQLConstants.java	Refactored SQL queries for webhook subscriptions: replaced comma-separated joins with explicit JOIN syntax, integrated conditions into JOIN clauses, updated expiry check, and added explicit type casting for PostgreSQL compatibility.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e0858d and a5fc2b4.

📒 Files selected for processing (1)

• components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/constants/SQLConstants.java (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: build-product (1, group1)
• GitHub Check: run-benchmark-test
• GitHub Check: build-product (3, group3)
• GitHub Check: build-carbon
• GitHub Check: build-product (2, group2)
• GitHub Check: build-product (4, group4)

🔇 Additional comments (2)

components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/constants/SQLConstants.java (2)

3848-3853: Improved query structure with explicit JOINs

The changes replace comma-separated tables with explicit JOIN syntax, which improves readability and better expresses the relationships between tables. Additionally, the WHERE clause now includes expiry time of 0 (expiry_at = 0) to capture subscriptions that never expire.

---

3870-3875: PostgreSQL compatibility enhancement

The PostgreSQL version of the query now uses proper type casting for the APPLICATION_ID field with the same JOIN structure improvements as the standard query. This maintains consistency across database platforms while handling PostgreSQL's type strictness.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.