Refactor DAO classes and DB scripts #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 3, 2015 16:00
dilee
changed the title
dilee
changed the title
added 11 commits
November 12, 2015 09:04
dilee
changed the title
prabushi
reviewed
Apr 4, 2019
| mappingIds.add(rs.getInt(1)); | ||
| } | ||
| return mappingIds; | ||
| // rs = stmt.getGeneratedKeys(); |
prabushi
reviewed
Apr 4, 2019
| @@ -39,6 +39,8 @@ | |||
| public int addOperation(Operation operation) throws OperationManagementDAOException { | |||
| int operationId; | |||
| PreparedStatement stmt = null; | |||
| ByteArrayOutputStream bao = null; | |||
| ObjectOutputStream oos = null; | |||
| try { | |||
prabushi
reviewed
Apr 4, 2019
| int operationId; | ||
| try { | ||
| operationId = super.addOperation(operation); | ||
| operation.setCreatedTimeStamp(new Timestamp(new java.util.Date().getTime()).toString()); | ||
| operation.setId(operationId); | ||
| operation.setEnabled(true); | ||
| ProfileOperation profileOp = (ProfileOperation) operation; | ||
| //ProfileOperation profileOp = (ProfileOperation) operation; |
There was a problem hiding this comment.
Remove commented line. And, can we change this to Java try with resource?
|
Add a description. |
dilee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Refactoring DAO classes and DB scripts.