Skip to content

Introduce app resident tenant domain extraction and get app resident tenant from pre process username #6586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShanChathusanda93
Copy link
Contributor

Proposed changes in this pull request

  • $subject

Copy link

sonarqubecloud bot commented Mar 6, 2025

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 47.75%. Comparing base (1b0a58e) to head (712600d).
Report is 350 commits behind head on master.

Files with missing lines Patch % Lines
.../authentication/framework/util/FrameworkUtils.java 0.00% 16 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6586      +/-   ##
============================================
+ Coverage     46.81%   47.75%   +0.93%     
- Complexity    15707    16537     +830     
============================================
  Files          1800     1824      +24     
  Lines        109453   114103    +4650     
  Branches      20205    21446    +1241     
============================================
+ Hits          51236    54485    +3249     
- Misses        51024    52209    +1185     
- Partials       7193     7409     +216     
Flag Coverage Δ
unit 32.01% <0.00%> (+3.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShanChathusanda93 ShanChathusanda93 force-pushed the app-resident-pre-process-branch branch from 3dc9c22 to 712600d Compare April 11, 2025 09:40
appTenantDomain = appResidentTenantDomain;
}
} catch (FrameworkException e) {
log.error("Error while getting the tenant domain of the application owner.", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the expected behavior when this exception is thrown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants