Skip to content

Bring First Class Support for AMR #6598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

Eranda2001
Copy link

@Eranda2001 Eranda2001 commented Mar 11, 2025

Proposed Changes in this Pull Request

  • Bring First Class Support for Customizable AMR Values

Related Issues

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2025

CLA assistant check
All committers have signed the CLA.

@Eranda2001 Eranda2001 marked this pull request as draft March 12, 2025 05:44
@Eranda2001 Eranda2001 force-pushed the feature-amr-copy branch 6 times, most recently from 8dec12c to b2eed6c Compare March 17, 2025 07:03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisit

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 69.49153% with 90 lines in your changes missing coverage. Please review.

Project coverage is 47.77%. Comparing base (fed7921) to head (5052916).
Report is 245 commits behind head on master.

Files with missing lines Patch % Lines
...cation/common/ApplicationAuthenticatorService.java 46.93% 24 Missing and 2 partials ⚠️
...ication/common/model/LocalAuthenticatorConfig.java 25.00% 12 Missing ⚠️
...ommon/dao/impl/AuthenticatorManagementDAOImpl.java 88.04% 10 Missing and 1 partial ⚠️
...ion/common/model/FederatedAuthenticatorConfig.java 0.00% 7 Missing ⚠️
...on/framework/config/model/AuthenticatorConfig.java 41.66% 6 Missing and 1 partial ⚠️
.../config/builder/FileBasedConfigurationBuilder.java 0.00% 5 Missing ⚠️
...mon/cache/SystemDefinedAuthenticatorsCacheKey.java 62.50% 1 Missing and 2 partials ⚠️
...on/cache/SystemDefinedAuthenticatorCacheEntry.java 66.66% 2 Missing ⚠️
...mmon/cache/SystemDefinedAuthenticatorCacheKey.java 75.00% 1 Missing and 1 partial ⚠️
...n/cache/SystemDefinedAuthenticatorsCacheEntry.java 66.66% 2 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6598      +/-   ##
============================================
+ Coverage     47.21%   47.77%   +0.56%     
- Complexity    15863    16337     +474     
============================================
  Files          1821     1829       +8     
  Lines        109986   112742    +2756     
  Branches      20260    21157     +897     
============================================
+ Hits          51929    53868    +1939     
- Misses        50859    51531     +672     
- Partials       7198     7343     +145     
Flag Coverage Δ
unit 32.12% <69.49%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Eranda2001 Eranda2001 marked this pull request as ready for review April 8, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants