-
Notifications
You must be signed in to change notification settings - Fork 687
Support selective configuration of store of local claims #4428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support selective configuration of store of local claims #4428
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
...arbon.user.core/src/main/java/org/wso2/carbon/user/core/common/AbstractUserStoreManager.java
Outdated
Show resolved
Hide resolved
|
Integration test runner |

Purpose
This pull request introduces enhancements to the way claims are managed and filtered in the user store, particularly focusing on supporting claims that are managed within specific user stores and those excluded from certain stores. The main changes involve extending the
Claimclass to track user store management properties, updating claim mapping logic to consider these new properties, and refining the methods that filter and count identity claims to use a more robust dialect-based check.Claim management enhancements:
managedInUserStoreandexcludedUserStoresproperties to theClaimclass, along with their respective getter and setter methods, to allow tracking whether a claim is managed in the user store and which user stores exclude it. [1] [2]SetinClaim.javato support the new property.Claim mapping and filtering improvements:
AbstractUserStoreManagerto use both the new claim properties and the user store domain when mapping attributes to local identity claims. This includes passing the domain to the mapping method and using the correct mapped attribute for each domain. [1] [2] [3] [4] [5]isIdentityStoreManagedClaimhelper method to determine if a claim is managed in the identity store, factoring in both themanagedInUserStoreandexcludedUserStoresproperties.Identity claim detection logic:
containsIdentityClaims,countIdentityClaims) to use the dialect constant (DEFAULT_CARBON_DIALECT) instead of a hardcoded URI substring, making the checks more robust and maintainable. [1] [2] [3] [4]Related Issues