Skip to content

Conversation

@PasinduYeshan
Copy link

@PasinduYeshan PasinduYeshan commented Oct 22, 2025

Purpose

This pull request introduces enhancements to the way claims are managed and filtered in the user store, particularly focusing on supporting claims that are managed within specific user stores and those excluded from certain stores. The main changes involve extending the Claim class to track user store management properties, updating claim mapping logic to consider these new properties, and refining the methods that filter and count identity claims to use a more robust dialect-based check.

Claim management enhancements:

  • Added managedInUserStore and excludedUserStores properties to the Claim class, along with their respective getter and setter methods, to allow tracking whether a claim is managed in the user store and which user stores exclude it. [1] [2]
  • Imported Set in Claim.java to support the new property.

Claim mapping and filtering improvements:

  • Updated the claim mapping logic in AbstractUserStoreManager to use both the new claim properties and the user store domain when mapping attributes to local identity claims. This includes passing the domain to the mapping method and using the correct mapped attribute for each domain. [1] [2] [3] [4] [5]
  • Introduced the isIdentityStoreManagedClaim helper method to determine if a claim is managed in the identity store, factoring in both the managedInUserStore and excludedUserStores properties.

Identity claim detection logic:

  • Refined the logic in methods that check for and count identity claims (containsIdentityClaims, countIdentityClaims) to use the dialect constant (DEFAULT_CARBON_DIALECT) instead of a hardcoded URI substring, making the checks more robust and maintainable. [1] [2] [3] [4]

Related Issues

sadilchamishka
sadilchamishka previously approved these changes Oct 23, 2025
@PasinduYeshan PasinduYeshan changed the title Introduce userStorePersistenceEnabled claim property Support selective configuration of store of local claims Nov 7, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PasinduYeshan
Copy link
Author

PasinduYeshan commented Nov 11, 2025

@PasinduYeshan
Copy link
Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants