Skip to content

Conversation

@KD23243
Copy link

@KD23243 KD23243 commented Dec 10, 2025

Related Issue

Purpose

This PR fixes the issue where Oracle-based external databases fail to validate connections when used as the local registry database in WSO2 Identity Server.

Previously, the validation query configuration in <IS_HOME>/repository/resources/conf/default.json and <IS_HOME>/repository/resources/conf/infer.json used an incorrect key database.$1.validationQuery instead of the correct database.$1.pool_options.validationQuery. As a result, the default SELECT 1 query was applied for all databases, causing connection validation failures in Oracle (SELECT 1 is invalid in Oracle).

Changes
Updated the JSON configuration to use database.$1.pool_options.validationQuery for all database types.

Manual Testing

Screen.Recording.2025-11-20.at.9.08.19.AM.mov

@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KD23243 KD23243 merged commit e3b7be5 into wso2:4.10.x Dec 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants