JDK21 compilation changes #4444
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
Comment on lines
59
to
60
|
|
||
| @Override |
There was a problem hiding this comment.
Log Improvement Suggestion No: 2
Suggested change
| @Override | |
| @Override | |
| public void stop(BundleContext bundleContext) throws Exception { | |
| log.info("Stopping CarbonBaseActivator bundle"); | |
| if (registration != null) { | |
| registration.unregister(); | |
| log.debug("ServerConfigurationService unregistered"); | |
| } |
|
|
||
| private void registerCarbonServlet(HttpService httpService, HttpContext defaultHttpContext) | ||
| throws ServletException, NamespaceException, InvalidSyntaxException { | ||
| private void registerCarbonServlet(HttpContext defaultHttpContext) throws InvalidSyntaxException { |
There was a problem hiding this comment.
Log Improvement Suggestion No: 5
Suggested change
| private void registerCarbonServlet(HttpContext defaultHttpContext) throws InvalidSyntaxException { | |
| private void registerCarbonServlet(HttpContext defaultHttpContext) throws InvalidSyntaxException { | |
| log.info("Registering CarbonServlet with service path: " + servicePath); |
Comment on lines
968
to
+969
| try { | ||
| CarbonCoreDataHolder.getInstance().getHttpService().unregister(servicePath); | ||
| CarbonCoreDataHolder.getInstance().unregisterServiceRegistrations(); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 6
Suggested change
| try { | |
| CarbonCoreDataHolder.getInstance().getHttpService().unregister(servicePath); | |
| CarbonCoreDataHolder.getInstance().unregisterServiceRegistrations(); | |
| try { | |
| log.info("Unregistering Carbon service registrations"); | |
| CarbonCoreDataHolder.getInstance().unregisterServiceRegistrations(); |
| private static final Log log = LogFactory.getLog(CarbonCoreActivator.class); | ||
| private CarbonCoreDataHolder dataHolder = CarbonCoreDataHolder.getInstance(); | ||
|
|
||
| public void start(BundleContext context) throws Exception { |
There was a problem hiding this comment.
Log Improvement Suggestion No: 7
Suggested change
| public void start(BundleContext context) throws Exception { | |
| public void start(BundleContext context) throws Exception { | |
| log.info("Starting Carbon Core bundle activation"); |
Comment on lines
71
to
72
| ", " + System.getProperty("user.timezone")); | ||
|
|
There was a problem hiding this comment.
Log Improvement Suggestion No: 8
Suggested change
| ", " + System.getProperty("user.timezone")); | |
| ", " + System.getProperty("user.timezone")); | |
| log.info("Carbon Core bundle activated successfully"); |
Comment on lines
+174
to
+177
| public void addServiceRegistration(ServiceRegistration<?> serviceRegistration) { | ||
|
|
||
| serviceRegistrations.add(serviceRegistration); | ||
| } |
There was a problem hiding this comment.
Log Improvement Suggestion No: 9
Suggested change
| public void addServiceRegistration(ServiceRegistration<?> serviceRegistration) { | |
| serviceRegistrations.add(serviceRegistration); | |
| } | |
| public void addServiceRegistration(ServiceRegistration<?> serviceRegistration) { | |
| serviceRegistrations.add(serviceRegistration); | |
| if (log.isDebugEnabled()) { | |
| log.debug("Added service registration: " + serviceRegistration.getReference().getProperty("objectClass")); | |
| } |
Comment on lines
+179
to
+184
| public void unregisterServiceRegistrations() { | ||
|
|
||
| for (ServiceRegistration<?> serviceRegistration : serviceRegistrations) { | ||
| serviceRegistration.unregister(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Log Improvement Suggestion No: 10
Suggested change
| public void unregisterServiceRegistrations() { | |
| for (ServiceRegistration<?> serviceRegistration : serviceRegistrations) { | |
| serviceRegistration.unregister(); | |
| } | |
| } | |
| public void unregisterServiceRegistrations() { | |
| log.info("Unregistering " + serviceRegistrations.size() + " service registrations"); | |
| for (ServiceRegistration<?> serviceRegistration : serviceRegistrations) { | |
| serviceRegistration.unregister(); | |
| } |
Comment on lines
+89
to
90
| if (isMeteringEnabled) { | ||
| requestDataPersister = new RequestDataPersisterTask(); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 11
Suggested change
| if (isMeteringEnabled) { | |
| requestDataPersister = new RequestDataPersisterTask(); | |
| if (isMeteringEnabled) { | |
| log.info("Metering is enabled, initializing request data persister"); | |
| requestDataPersister = new RequestDataPersisterTask(); |
| ) | ||
| public class DataSourceService { | ||
|
|
||
| public List<CarbonDataSource> getAllDataSources() throws DataSourceException { |
There was a problem hiding this comment.
Log Improvement Suggestion No: 12
Suggested change
| public List<CarbonDataSource> getAllDataSources() throws DataSourceException { | |
| public List<CarbonDataSource> getAllDataSources() throws DataSourceException { | |
| log.info("Retrieving all data sources"); |
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning