Implement port resolution for LDAP URLs to add default ports if not specified #4445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
| // if embedded-ldap is not enabled, | ||
| connectionURL = realmConfig.getUserStoreProperty(LDAPConstants.CONNECTION_URL); | ||
| } | ||
| connectionURL = resolvePort(rawConnectionURL); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| connectionURL = resolvePort(rawConnectionURL); | |
| connectionURL = resolvePort(rawConnectionURL); | |
| log.debug("Resolved LDAP connection URL: {}", connectionURL); |
Comment on lines
+1125
to
+1127
| if (StringUtils.isEmpty(url)) { | ||
| return url; | ||
| } |
There was a problem hiding this comment.
Log Improvement Suggestion No: 2
Suggested change
| if (StringUtils.isEmpty(url)) { | |
| return url; | |
| } | |
| if (StringUtils.isEmpty(url)) { | |
| log.debug("LDAP URL is empty, returning as-is"); | |
| return url; | |
| } |
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 | ||
| #### Log Improvement Suggestion No: 2 |
ThaminduR
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request enhances the handling of LDAP connection URLs to ensure standard ports are automatically applied when not explicitly defined. It also refactors the underlying logic for improved maintainability.
In alignment with the LDAP URL specification, the system now correctly infers the default port based on the protocol:
ldap://defaults to port389ldaps://defaults to port636Related Issue