-
Notifications
You must be signed in to change notification settings - Fork 691
[master] Add DocumentBuilderFactory property to wso2server.bat #4469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.10.x
Are you sure you want to change the base?
Conversation
WalkthroughA Java system property for the XML parser factory ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Integration test runner: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|

Purpose
In WSO2 IS, when
SSOUtils::marshallis called, the parser pool is initialized before the runtimeDocumentBuilderFactoryis set. This causes OpenSAML to create a JDKcom.sun.org.apache.xerces.internal.dom.DocumentImplinstead of the expectedorg.apache.xerces.dom.DeferredDocumentImpl, leading to errors when unmarshalling and then marshalling a SAML XML object.Related Issues
javax.xml.parsers.DocumentBuilderFactoryproperty is not honoured and leads toDOM Element node adoption failederror product-is#20441Related PRs
Summary by CodeRabbit