-
Notifications
You must be signed in to change notification settings - Fork 41
Update Chat Agent Documentation to Include Tracing Feature #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughRewrites the chat agents guide to a BI-first, provider-agnostic flow (default WSO2 Integrator: BI, optional external providers), moves API-key handling to VS Code configurables and runtime prompts, updates model/memory/tools flows, introduces built-in tracing and Jaeger guidance, and replaces assets with BI-branded visuals. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as VS Code (Developer)
participant Agent as Chat Agent (BI runtime)
participant Model as Model Provider (WSO2 / External)
participant Tracing as Tracing UI / Jaeger
Dev->>Agent: Create/configure agent (provider, model, memory, functions)
Dev->>Model: Optionally add credentials via VS Code configurable / Expression Helper
Dev->>Agent: Enable Tracing (VS Code command)
Dev->>Agent: Send chat message
Agent->>Model: LLM request
Model-->>Agent: LLM response
Agent->>Agent: Invoke Function/Tool (if applicable)
Agent->>Tracing: Emit built-in traces (tool calls, LLM calls, logs)
Tracing->>Dev: Display logs / visualization (Show logs)
alt Forward to Jaeger
Agent->>Tracing: Forward traces to Jaeger endpoint
Tracing->>Dev: External visualization in Jaeger
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10–15 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0cd888e to
8b5b95d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md (1)
122-126: Clarify Step 8's flow relationship to Step 7.Step 7 instructs users to click Chat and run the integration, but Step 8 repeats these actions (lines 122-123). While this is necessary because tracing must be enabled before execution, the documentation should explicitly clarify that Step 8 requires a fresh run with tracing enabled, rather than continuing the prior interaction. Consider rewording to emphasize this is a new execution with tracing active.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
en/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/2.create-an-agent.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/3.configure-behaviour.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/4.configure-model.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/5.create-function.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/6.create-agent-tool.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/7.interact-with-agent.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/8.tracing.gifis excluded by!**/*.gif
📒 Files selected for processing (1)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
🔇 Additional comments (2)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md (2)
85-99: Both referenced GIF files exist and are correctly specified. No action required.
39-40: Verify VS Code command names are accurate.The documentation references a command to "Configure default WSO2 Model Provider", but the exact command names in the VS Code extension cannot be definitively confirmed from available public documentation:
- Line 40:
Ballerina: Configure default WSO2 model provider- Line 121:
Ballerina: Enable TracingThese commands must match precisely with what's available in the Ballerina/BI extension, as incorrect names will prevent users from following the tutorial. Confirm these command names are correct in the current version of the extension.
b7321bc to
d302b9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md (1)
50-58: Consider clarifying the placement of the configurable steps within Step 4.The API key configurable setup is currently nested within a note block in the middle of the numbered steps (lines 50-58). While the steps are clear, readers might benefit from slightly clearer demarcation that this is still part of Step 4's model configuration flow, not a separate step. The current note placement could be misinterpreted as optional guidance rather than a recommended best practice for externalizing secrets.
Consider adding a brief introductory phrase like "To securely configure the API key, follow these steps:" immediately before the numbered list, or restructure the note to make the conditional flow more explicit (e.g., "If using OpenAI or another external provider, configure the API key as follows:").
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
en/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/2.create-an-agent.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/3.configure-behaviour.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/4.configure-model.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/5.create-function.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/6.create-agent-tool.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/7.interact-with-agent.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/8.tracing.gifis excluded by!**/*.gif
📒 Files selected for processing (1)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
🔇 Additional comments (2)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md (2)
120-121: Verify the exact VS Code command name for enabling tracing.The PR objectives reference the command as
Ballerina: Enable Tracing (Experimental), but line 121 showsBallerina: Enable Tracing(without the "(Experimental)" suffix). Confirm which command name is correct in the current version of BI/Ballerina.
37-41: Verify the exact VS Code command for configuring the default WSO2 model provider.Confirm that
Ballerina: Configure default WSO2 model provideris the correct command name in the current BI version, or if it has a different name or suffix (e.g., "(Experimental)").
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
Outdated
Show resolved
Hide resolved
d302b9b to
441c8b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
en/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/2.create-an-agent.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/3.configure-behaviour.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/4.configure-model.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/5.create-function.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/6.create-agent-tool.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/7.interact-with-agent.gifis excluded by!**/*.gifen/docs/assets/img/integration-guides/ai/agents/introduction-to-chat-agents/8.tracing.gifis excluded by!**/*.gif
📒 Files selected for processing (1)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
🔇 Additional comments (6)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md (6)
10-34: Minor UI naming updates look good.References to "WSO2 Integrator: BI" are consistent and asset references are intact.
39-40: Verify VS Code command names against product implementation.Line 39-40 references
Ballerina: Configure default WSO2 model provider, and line 121 referencesBallerina: Enable Tracing. However, the PR objectives mention the tracing command should be "Ballerina: Enable Tracing (Experimental)". Confirm these command names match the actual VS Code extension implementation, particularly whether the tracing command includes the "(Experimental)" suffix.Also applies to: 121-121
60-60: Verify model type identifier.Line 60 specifies
gpt-4.1as the model type. Confirm this is a valid OpenAI model identifier for the current API version. If this value comes from a dropdown or configuration schema, verify it matches the expected format (e.g., whether it should begpt-4-turbo,gpt-4-1106-preview, or similar).
76-99: Verify UI terminology and asset availability.Line 92 references "Use Function" option for adding tools. Confirm this matches the actual BI UI wording. Additionally, verify that both asset files referenced exist:
- Line 86:
6.add-functions.gif- Line 99:
6.create-agent-tool.gifThe asset mismatch issue from the previous review appears resolved, but confirm the filenames exist in the asset directory.
112-126: Tracing section is well-structured and comprehensive.The new Step 8 provides clear instructions for enabling built-in tracing and viewing detailed execution logs. The workflow is logical: enable via VS Code command → run integration → interact with agent → view traces. This directly addresses the PR objectives for documenting the tracing feature.
129-135: Verify external documentation links are current.Lines 133-135 reference external documentation for Jaeger integration and Ballerina observability tools. Confirm these links are current and resolve correctly, particularly the Jaeger documentation URL on line 133 and the Ballerina observability tools page on line 135.
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
Outdated
Show resolved
Hide resolved
441c8b9 to
d6f9eda
Compare
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
Outdated
Show resolved
Hide resolved
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
Outdated
Show resolved
Hide resolved
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
Outdated
Show resolved
Hide resolved
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
Outdated
Show resolved
Hide resolved
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
Outdated
Show resolved
Hide resolved
1cb373f to
2212982
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md (2)
39-39: Inconsistent keyboard shortcut formatting.Line 39 formats the keyboard shortcut as a single backtick block (
`Ctrl/Cmd + Shift + P`), while line 123 breaks it into separate backticks (`Ctrl/Cmd` + `Shift` + `P`). Adopt a consistent style throughout the document.🔎 Proposed fix to standardize on line 123's approach
- Press `Ctrl/Cmd + Shift + P` to open the VS Code Command Palette. + Press `Ctrl/Cmd` + `Shift` + `P` to open the VS Code Command Palette.Also applies to: 123-123
110-113: Consider explicitly documenting the configurables prompt in Step 7.Line 69 correctly references Step 7 as the point where users are prompted for configurable values. However, Step 7 currently only mentions being prompted to "run the integration" (line 111). For clarity, consider explicitly noting that users will also be prompted to provide values for any configurables they defined (e.g.,
openAiApiKey) when starting the integration. This would reinforce the earlier guidance in Step 4 about configurable setup.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-11-12T05:34:19.589Z
Learnt from: dulajdilshan
Repo: wso2/docs-bi PR: 169
File: en/docs/deploy/deployment-best-practices/network-level-security.md:1-20
Timestamp: 2025-11-12T05:34:19.589Z
Learning: In the wso2/docs-bi repository documentation files, using h3 (###) subsection headings directly under h1 (#) titles is an intentional style choice, even though it violates standard markdown heading increment rules.
Applied to files:
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
📚 Learning: 2025-11-12T05:34:18.459Z
Learnt from: dulajdilshan
Repo: wso2/docs-bi PR: 169
File: en/docs/deploy/deployment-best-practices/os-level-security.md:1-25
Timestamp: 2025-11-12T05:34:18.459Z
Learning: In the WSO2 docs-bi repository, specifically in deployment best practices documentation files under en/docs/deploy/deployment-best-practices/, using h3 (###) headings directly after h1 titles (instead of h2) is intentional and should not be flagged.
Applied to files:
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
🔇 Additional comments (3)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md (3)
37-69: LGTM on configurable API key best practice.The new configurables workflow for handling the OpenAI API key (lines 56–61) is well-documented and follows security best practices by externalizing sensitive values. The reference to the Configurations guide is helpful, and the note about prompting at runtime is valuable context for users.
115-138: Comprehensive tracing documentation with dual-platform guidance.The new Step 8 effectively documents both the built-in tracing feature (with clear VS Code command and UI steps) and external observability integration via Jaeger. The structured flow from enabling tracing → running the integration → viewing logs is intuitive, and the references to Ballerina's observability documentation provide good extensibility guidance.
124-124: Verify the VS Code command name for the tracing feature.The documented command name at line 124 is
Ballerina: Enable Tracing, but this command does not appear in publicly available Ballerina VS Code extension documentation. If this is a new feature being introduced, verify whether the command should include the(Experimental)suffix as referenced in the PR objectives, or confirm the final command name with the extension team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-11-12T05:34:19.589Z
Learnt from: dulajdilshan
Repo: wso2/docs-bi PR: 169
File: en/docs/deploy/deployment-best-practices/network-level-security.md:1-20
Timestamp: 2025-11-12T05:34:19.589Z
Learning: In the wso2/docs-bi repository documentation files, using h3 (###) subsection headings directly under h1 (#) titles is an intentional style choice, even though it violates standard markdown heading increment rules.
Applied to files:
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
📚 Learning: 2025-11-12T05:34:18.459Z
Learnt from: dulajdilshan
Repo: wso2/docs-bi PR: 169
File: en/docs/deploy/deployment-best-practices/os-level-security.md:1-25
Timestamp: 2025-11-12T05:34:18.459Z
Learning: In the WSO2 docs-bi repository, specifically in deployment best practices documentation files under en/docs/deploy/deployment-best-practices/, using h3 (###) headings directly after h1 titles (instead of h2) is intentional and should not be flagged.
Applied to files:
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
🔇 Additional comments (1)
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md (1)
124-124: Verify the VS Code command name against the PR objectives and issue #2136.Line 124 references
Ballerina: Enable Tracing, but this documentation should be verified to confirm whether the command includes the(Experimental)suffix as specified in the PR objectives and issue #2136. Check the actual VS Code command palette or the PR details to determine the exact command name that should be documented.
en/docs/integration-guides/ai/agents/introduction-to-chat-agents.md
Outdated
Show resolved
Hide resolved
9f0f82b to
a8c9619
Compare
Purpose
Resolves wso2/product-ballerina-integrator#2136
It updates the chat agent documentation to add steps for enabling and using the tracing feature and align existing documentation with the latest UI changes introduced in BI 1.5.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.