Skip to content

Fix image loading issue in MTLS doc#125

Open
DivyaPremanantha wants to merge 3 commits intowso2:mainfrom
DivyaPremanantha:mtls-new
Open

Fix image loading issue in MTLS doc#125
DivyaPremanantha wants to merge 3 commits intowso2:mainfrom
DivyaPremanantha:mtls-new

Conversation

@DivyaPremanantha
Copy link
Copy Markdown
Contributor

@DivyaPremanantha DivyaPremanantha commented Jan 22, 2026

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Summary by CodeRabbit

  • Documentation
    • Corrected image references and relative paths for consistent resource loading
    • Enhanced visual presentation with improved image sizing and styling
    • Fixed minor text formatting inconsistencies in authentication documentation

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 22, 2026

Walkthrough

Updated documentation file for mutual TLS configuration, correcting relative image paths, adding inline width styling to images, and fixing a minor typo in sentence formatting.

Changes

Cohort / File(s) Summary
Documentation Updates
en/docs/develop-api-proxy/authentication-and-authorization/secure-communication-between-the-bijira-gateway-and-your-backend-with-mutual-tls.md
Corrected image reference paths from ../../../assets/... to ../../assets/...; added inline style attributes to images with width specifications (300px, 500px); fixed typo by removing extra space ("This opens the certificate" → "This opens the certificate")

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Hops with glee

Paths aligned and widths now set,
The finest docs you ever met,
A typo squashed with gentle care—
Pure perfection, shining there! 📚

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template structure with no substantive content filled in. All sections remain as placeholder text with no actual information provided about the fix. Fill in at least the Purpose, Goals, and Approach sections with details about what image loading issue was fixed, why it matters, and how the relative path changes resolve it.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix image loading issue in MTLS doc' directly matches the PR's main purpose of fixing image loading issues in the MTLS documentation by correcting relative paths and adjusting image styling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
en/docs/develop-api-proxy/authentication-and-authorization/secure-communication-between-the-bijira-gateway-and-your-backend-with-mutual-tls.md (1)

23-23: Correct internal document links: use ../../ instead of ../../../.

The internal links at lines 23, 41, and 69 use ../../../create-api-proxy/my-apis/http/import-api-contract/, which goes up one directory level too many. The correct relative path from en/docs/develop-api-proxy/authentication-and-authorization/ to the target file at en/docs/create-api-proxy/my-apis/http/import-api-contract.md is ../../create-api-proxy/my-apis/http/import-api-contract/. This aligns with the correction made to image paths in this document (from ../../../assets/ to ../../assets/).

🤖 Fix all issues with AI agents
In
`@en/docs/develop-api-proxy/authentication-and-authorization/secure-communication-between-the-bijira-gateway-and-your-backend-with-mutual-tls.md`:
- Line 85: The sentence "This opens the  certificate for you to view and
download." contains an extra space between "the" and "certificate"; edit the
markdown content in
secure-communication-between-the-bijira-gateway-and-your-backend-with-mutual-tls.md
to remove the double space so it reads "This opens the certificate for you to
view and download." and save the file.
🧹 Nitpick comments (1)
en/docs/develop-api-proxy/authentication-and-authorization/secure-communication-between-the-bijira-gateway-and-your-backend-with-mutual-tls.md (1)

49-49: Consider using CSS classes instead of inline styles for better maintainability.

While the inline styles {: style="width:300px"} and {: style="width:500px"} work correctly, using CSS classes would improve maintainability and allow for global style updates without modifying individual markdown files.

♻️ Alternative approach using CSS classes

If your documentation framework supports custom CSS classes, consider defining classes like:

.img-dialog { width: 300px; }
.img-large { width: 500px; }

Then update the markdown to:

-![Generate new key pair](../../assets/img/authentication-and-authorization/generate-new-key-pair.png){: style="width:300px"}
+![Generate new key pair](../../assets/img/authentication-and-authorization/generate-new-key-pair.png){: .img-dialog}

This approach centralizes styling and makes future adjustments easier.

Also applies to: 55-55, 59-59, 77-77, 83-83, 87-87, 100-100

![View and download certificate](../../assets/img/authentication-and-authorization/view-and-download.png){: style="width:500px"}

This opens the certificate for you to view and download.
This opens the certificate for you to view and download.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Inconsistent with AI summary - typo appears unfixed.

The AI summary indicates that line 85 was corrected to remove an extra space ("This opens the certificate" → "This opens the certificate"), but the current code still shows "This opens the certificate" with a double space between "the" and "certificate".

📝 Verify and apply the typo fix
-       This opens the  certificate for you to view and download.
+       This opens the certificate for you to view and download.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
This opens the certificate for you to view and download.
This opens the certificate for you to view and download.
🤖 Prompt for AI Agents
In
`@en/docs/develop-api-proxy/authentication-and-authorization/secure-communication-between-the-bijira-gateway-and-your-backend-with-mutual-tls.md`
at line 85, The sentence "This opens the  certificate for you to view and
download." contains an extra space between "the" and "certificate"; edit the
markdown content in
secure-communication-between-the-bijira-gateway-and-your-backend-with-mutual-tls.md
to remove the double space so it reads "This opens the certificate for you to
view and download." and save the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant