-
Notifications
You must be signed in to change notification settings - Fork 376
Fix: Add port configuration behavior warning for x509 authenticator (Product IS issue #21293) #5768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix: Add port configuration behavior warning for x509 authenticator (Product IS issue #21293) #5768
Conversation
…product-is#21293) This commit adds documentation clarification about x509 authenticator port configuration behavior across all affected versions (6.0.0, 6.1.0, 7.0.0, 7.1.0, 7.2.0, and next). The x509 transport port setting overrides the proxyPort configuration, which can cause connection issues when deploying behind a proxy or load balancer. This documentation update warns users about this behavior and provides guidance on proper configuration. Affected versions: - 6.0.0: en/identity-server/6.0.0/docs/guides/mfa/x509.md - 6.1.0: en/identity-server/6.1.0/docs/guides/mfa/x509.md - 7.0.0+: en/includes/guides/authentication/mfa/add-x509-login.md (shared by 7.0.0, 7.1.0, 7.2.0, and next) 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
|
wso2-engineering-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
WalkthroughDocumentation updates across three X509 MFA configuration guides adding "Port configuration behavior" warning blocks explaining how custom transport ports override proxyPort for all redirect URLs, with minor whitespace adjustments. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR was automatically generated by Claude AI.
Affected Versions
This PR updates documentation for ALL affected versions:
en/identity-server/6.0.0/docs/guides/mfa/x509.mden/identity-server/6.1.0/docs/guides/mfa/x509.mden/includes/guides/authentication/mfa/add-x509-login.md(shared include file)Changes Made
Added a warning section explaining that:
proxyPortsetting in[transport.https.properties]Style Scope Verification
Microsoft Style Guidelines have been applied ONLY to the newly added warning content. No modifications were made to existing documentation content beyond adding the new warning section.
Verification
mkdocs build🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.