-
Notifications
You must be signed in to change notification settings - Fork 376
Fix: Update push provider documentation to include extension mechanism for all affected versions (Product IS issue #26443) #5793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…m for all affected versions (product-is#26443) This commit updates the push provider documentation to reflect that IS 7.1.0 and later versions support configuring any push provider as an extension, not just FCM. Changes: - Updated introduction to clarify FCM is the default push notification provider - Added new section 'Configure custom push providers' with information about: * Extension mechanism for implementing custom push providers * Support for multiple active push providers * Device registration with specific push provider selection * Examples including HMS Push Kit for Huawei devices - Reorganized content with clearer headings following Microsoft Style Guide - Added prerequisites and implementation steps for custom extensions Affected versions: 7.1.0, 7.2.0, and next (all use the same include file) 🤖 Generated with Claude Code (https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
|
wso2-engineering-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
WalkthroughThis pull request updates documentation for push provider configuration by restructuring content, correcting terminology (Firebase Cloud Messaging, APNs), establishing FCM as the default provider, and adding a comprehensive guide for custom push provider extensions with support for alternative device services. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
en/includes/guides/notification-channels/configure-push-provider.md (2)
5-7: Clarify the APNs configuration requirement.Line 6 states FCM "has the capability to send push notifications to iOS devices through Apple Push Notification Service (APNs)" but then says "you need to configure APNs separately." This could imply a contradiction—consider rephrasing to clarify that APNs credentials must be configured separately even though FCM can send through APNs.
For example: "FCM can relay push notifications to iOS through APNs, but you must configure APNs credentials separately in Firebase to enable this capability."
49-68: Implementation steps could benefit from more concrete guidance.Lines 49–68 provide high-level steps but lack detail on:
- The specific interface or contract custom providers must implement
- Concrete example of "push provider identifier" format and how it flows during device registration (referenced in line 64)
- Where/how to register the extension in {{ product_name }} deployment
Consider linking to a reference implementation or code example, even if minimal. If these details are intentionally deferred to the "extension development documentation" (line 74), ensure that cross-reference is discoverable to users.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
en/includes/guides/notification-channels/configure-push-provider.md(2 hunks)
🧰 Additional context used
🪛 LanguageTool
en/includes/guides/notification-channels/configure-push-provider.md
[style] ~72-~72: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 3770 characters long)
Context: ... and proper validation of push tokens. !!! note For detailed guidance on imple...
(EN_EXCESSIVE_EXCLAMATION)
🔇 Additional comments (2)
en/includes/guides/notification-channels/configure-push-provider.md (2)
1-24: Clear restructuring and terminology fixes.The restructuring to separate FCM configuration into its own section and the terminology corrections (Firebase Cloud Messaging, APNs) improve clarity and accuracy. Line 3's clarification that FCM is the default provider—not the only option—sets proper context for the new custom provider section.
25-75: Comprehensive custom provider guidance with good real-world context.The new section effectively explains the extension mechanism, prerequisites, and implementation steps. The HMS Push Kit example (line 27) is helpful and concrete. Security considerations (line 71) and reference to version-specific extension docs (line 74) are appropriate for a guide-level reference.
This PR was automatically generated by Claude AI.
Issue: wso2/product-is#26443
Type: Documentation
Summary: Updated the push provider documentation to reflect that WSO2 Identity Server 7.1.0 and later versions support configuring any push provider as an extension, not just Firebase Cloud Messaging (FCM). The documentation now includes information about the extension mechanism for custom push providers, support for multiple active push providers, and how devices can specify which provider to use during registration.
Affected Versions: 7.1.0, 7.2.0, and next
All three versions use the same include file at
en/includes/guides/notification-channels/configure-push-provider.md, so a single change updates all affected versions.Changes Made:
Style Scope Verification: Microsoft Style Guidelines have been applied ONLY to newly added content without modifying existing content style unless specifically requested.
Verification:
mkdocs buildSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.