Skip to content

Conversation

@SujanSanjula96
Copy link
Contributor

@SujanSanjula96 SujanSanjula96 commented Dec 21, 2025

Purpose

$Subject

Summary by CodeRabbit

  • Documentation
    • Added B2B organization login guide with OIDC and SAML authentication flow examples and organization discovery options
    • Added new inheritance guides covering UI branding, email and SMS templates, and user attributes
    • Updated documentation navigation to expose new organization management guides

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 21, 2025

Walkthrough

Added new documentation guide for B2B organization login flows supporting OIDC and SAML, with examples for organization discovery via authentication requests. Updated navigation across two documentation versions and expanded inheritance-related guide entries in organization management sections.

Changes

Cohort / File(s) Summary
B2B Organization Login Guides
en/identity-server/7.2.0/docs/guides/organization-management/b2b-organization-login.md, en/identity-server/next/docs/guides/organization-management/b2b-organization-login.md, en/includes/guides/organization-management/b2b-organization-login.md
Added new shared guide for B2B organization login with OIDC and SAML examples, organization discovery prompts (fidp=OrganizationSSO), and conditional authentication script examples. Version-specific files include template variables and delegate content to shared include.
Navigation Configuration Updates
en/identity-server/7.2.0/mkdocs.yml, en/identity-server/next/mkdocs.yml
Added navigation entries for "B2B organization login" guide and expanded "Inheritance in organizations" section with new entries for UI branding inheritance and Email and SMS templates inheritance.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Review effort is minimal as changes consist entirely of documentation content addition and straightforward navigation configuration updates with no complex logic or behavioral changes
  • Focus areas: verify shared include content accuracy and confirm navigation file syntax is correct across both version configurations

Poem

🐰 Through docs we hop, organization flows take shape,
B2B logins clear, no secrets to escape,
Inheritance threads, from branding to mail,
Navigation branches bloom—our guide won't fail! 📖✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete and contains only a placeholder '$Subject' in the Purpose section without substantive content. Required sections like Test environment and Security checks are missing. Replace the placeholder with an actual description of the purpose, add Test environment details, and confirm security checks have been performed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add docs for B2B login options' is directly related to the main changes, which add documentation for B2B organization login flows across multiple documentation files and versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8bbd6a and a1ef96e.

📒 Files selected for processing (5)
  • en/identity-server/7.2.0/docs/guides/organization-management/b2b-organization-login.md (1 hunks)
  • en/identity-server/7.2.0/mkdocs.yml (1 hunks)
  • en/identity-server/next/docs/guides/organization-management/b2b-organization-login.md (1 hunks)
  • en/identity-server/next/mkdocs.yml (1 hunks)
  • en/includes/guides/organization-management/b2b-organization-login.md (1 hunks)
🔇 Additional comments (8)
en/identity-server/7.2.0/docs/guides/organization-management/b2b-organization-login.md (1)

1-4: LGTM! Clean template wrapper.

The file correctly defines template variables and includes the shared guide content. The structure follows the standard pattern for version-specific documentation that reuses shared content.

en/identity-server/7.2.0/mkdocs.yml (1)

786-786: LGTM! Navigation entry added correctly.

The new "B2B organization login" navigation item is properly placed under the Organizations section and correctly references the new guide file.

en/identity-server/next/docs/guides/organization-management/b2b-organization-login.md (1)

1-4: LGTM! Consistent with 7.2.0 version.

The "next" version wrapper is identical to the 7.2.0 version, which is appropriate for shared content. Both versions use the same template variables and include the same shared guide.

en/identity-server/next/mkdocs.yml (1)

787-787: LGTM! Navigation entry consistent across versions.

The "next" version navigation update matches the 7.2.0 version, maintaining consistency across documentation versions.

en/includes/guides/organization-management/b2b-organization-login.md (4)

30-55: The fidp=OrganizationSSO parameter usage is correct. The fidp query parameter is the standard mechanism for specifying federated identity providers, OrganizationSSO is the correct identifier for organization SSO in the B2B context, and the value is case-sensitive and documented across multiple organization management guides.


75-76: Verify parameter names for organization discovery.

Line 76 lists org and orgHandle as discovery parameters alongside orgId. However, based on Clerk's official documentation, organizations are identified by either their ID or slug—not by "orgHandle." Verify that these parameter names are accurate and either:

  1. Correct orgHandle to the appropriate parameter name (likely slug)
  2. Verify whether org is a supported alias or should be orgId
  3. Add clarification about which identifiers are supported for discovery

7-27: Verify endpoint paths against product documentation and implementation.

The OIDC and SAML endpoint paths should be verified against your product's actual API implementation. Standard parameters (client_id, redirect_uri, scope, response_type, and spEntityID) are correct, but confirm:

  • Whether /oauth2/authorize matches your OIDC implementation (some products use versioned paths like /oauth2/v2.0/authorize)
  • Whether /samlsso is the correct SAML endpoint path for your product
  • Whether any additional required parameters are missing from these examples

57-73: Inconsistency: IDP identifier mismatch between sections.

The fidp parameter examples (lines 34, 44, 52) use fidp=OrganizationSSO, but the conditional authentication script (line 65) uses idp: "SSO". Verify whether these refer to the same identity provider or require different identifiers.

Additionally, the conditional logic on line 65 checks !context.steps[1].idp within an executeStep(1, ...) call. Since step 1 is currently executing, context.steps[1].idp may not be set yet, which could affect the intended behavior. Confirm that this reference is correct for detecting whether to use the Organization SSO option.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant