Skip to content

Conversation

@Malith-19
Copy link
Contributor

@Malith-19 Malith-19 commented Jan 5, 2026

Purpose

Test environment

Security checks

Summary by CodeRabbit

  • Documentation
    • Added a subsection clarifying that when the refresh-token renewal setting is disabled, renewed refresh tokens inherit the remaining validity period of the original token.
    • Notes this is documentation-only with no change to runtime behavior.
    • Helps administrators understand token expiry and renewal handling.

✏️ Tip: You can customize this high-level summary in your review settings.

Preview

Screenshot 2026-01-05 at 12 29 52

@coderabbitai
Copy link

coderabbitai bot commented Jan 5, 2026

Walkthrough

Added a new subsection to the OIDC settings documentation explaining that when the "extend expiry time" setting is false, renewed refresh tokens inherit the remaining validity period of the original refresh token.

Changes

Cohort / File(s) Summary
Documentation
en/includes/guides/fragments/manage-app/oidc-settings/refresh-token.md
Added subsection "Extend expiry time of renewed refresh token" describing that renewed refresh tokens retain the remaining validity period of the original token when the extend-expiry setting is false.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A note on tokens, clear and bright,
Renewed time kept within its light.
Settings whisper what rules will hold,
Docs hop in — precise and bold.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating documentation with a new application configuration setting for refresh token expiry.
Description check ✅ Passed The description includes the Purpose section with a linked issue and covers security checks, but the Test environment section is empty and Related PRs section is missing entirely.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
en/includes/guides/fragments/manage-app/oidc-settings/refresh-token.md (1)

10-11: Clarify behavior for both enabled and disabled states.

The documentation only describes the false state but doesn't explain what happens when the setting is true. Additionally, the phrasing differs from the nearby "Renew refresh token" section, which uses a more user-friendly pattern.

For completeness, explain both states and consider aligning with the existing section's phrasing pattern to improve consistency and clarity.

🔎 Proposed documentation improvement
 #### Extend expiry time of renewed refresh token
-When this configuration is set to `false`, renewed refresh tokens carry the remaining validity period of the original refresh token.
+If you enable this option, renewed refresh tokens will have their expiry time extended based on the configured refresh token expiry time. If you disable this option, renewed refresh tokens carry the remaining validity period of the original refresh token.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a199dfd and 2825066.

📒 Files selected for processing (1)
  • en/includes/guides/fragments/manage-app/oidc-settings/refresh-token.md

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
en/includes/guides/fragments/manage-app/oidc-settings/refresh-token.md (1)

10-13: Document both configuration states for clarity.

The explanation only describes the behavior when false. Users need to understand what happens when this setting is true (presumably that renewed refresh tokens receive a new full expiry time). Consider revising to match the documentation pattern used in the "Renew refresh token" section above, which explains both the default and configured behavior.

For example:

When this configuration is set to `false`, renewed refresh tokens carry the remaining validity period of the original refresh token. When set to `true`, renewed refresh tokens receive a new expiry time based on the configured refresh token expiry time.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2c629e and e805701.

📒 Files selected for processing (1)
  • en/includes/guides/fragments/manage-app/oidc-settings/refresh-token.md

@Malith-19 Malith-19 merged commit d3452be into wso2:master Jan 5, 2026
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants