-
Notifications
You must be signed in to change notification settings - Fork 376
Added redirects to the manage attributes doc #5814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added redirects to the manage attributes doc #5814
Conversation
WalkthroughAdded a redirect mapping in several MkDocs configs to point Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
en/identity-server/7.2.0/mkdocs.yml (1)
445-445: LGTM! Redirect is correctly configured.The redirect mapping is syntactically correct and points to a valid target path in the navigation structure (line 693).
However, consider optimizing the redirect chains created by this change. Lines 230-231 currently redirect to
guides/users/attributes/manage-attributes.md, which now redirects again to the final destination. For better performance and maintainability, those entries could be updated to point directly toguides/users/attributes/user-attributes/manage-attributes.md.🔎 Script to identify all redirects that may benefit from updating
#!/bin/bash # Find all redirects pointing to the old path that now has its own redirect rg -n "guides/users/attributes/manage-attributes.md" en/identity-server/*/mkdocs.yml | \ grep -v "user-attributes/manage-attributes.md" | \ grep "redirect_maps" -A 200This will help identify any other redirect chains across all version files that could be optimized.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
en/identity-server/7.0.0/mkdocs.ymlen/identity-server/7.1.0/mkdocs.ymlen/identity-server/7.2.0/mkdocs.ymlen/identity-server/next/mkdocs.yml
🔇 Additional comments (3)
en/identity-server/7.0.0/mkdocs.yml (1)
439-439: Redirect for legacy manage-attributes path looks correctThe new mapping cleanly forwards
guides/users/attributes/manage-attributes.mdto the new canonical location underuser-attributes/manage-attributes.md, consistent with the nav entry and existing redirects in this section.en/identity-server/7.1.0/mkdocs.yml (1)
442-442: Consistent manage-attributes redirect for 7.1.0This redirect aligns 7.1.0 with the other versions by routing the old
guides/users/attributes/manage-attributes.mdpath to the currentuser-attributes/manage-attributes.mdpage. No issues spotted.en/identity-server/next/mkdocs.yml (1)
445-445: Next version redirect matches earlier versionsThe added redirect for
guides/users/attributes/manage-attributes.mdcorrectly targetsguides/users/attributes/user-attributes/manage-attributes.mdand maintains consistency with 7.0.0 and 7.1.0. Looks good as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
en/asgardeo/mkdocs.yml (1)
172-173: Consider removing trailing blank lines.These trailing blank lines after the redirect entry could be removed for consistency and cleaner formatting.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
en/asgardeo/mkdocs.yml
🔇 Additional comments (1)
en/asgardeo/mkdocs.yml (1)
171-171: LGTM! Redirect mapping correctly added.The redirect mapping for the manage attributes documentation is properly configured and aligns with the navigation structure (line 396). This ensures backward compatibility for existing links after the documentation restructure.
Purpose
$subject
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.