-
Notifications
You must be signed in to change notification settings - Fork 82
Add supported data types documentation and Ballerina Central links for Ballerina Module #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…a module, including supported data types, compile-time validation, and runtime mapping examples.
…ith links to Ballerina Central.
WalkthroughExpanded the Ballerina module overview: added Ballerina Central links, Supported Data Types, compile-time validation rules for Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
en/docs/develop/customizations/ballerina-module/overview.md(3 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
en/docs/develop/customizations/ballerina-module/overview.md
99-99: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
144-144: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
🔇 Additional comments (4)
en/docs/develop/customizations/ballerina-module/overview.md (4)
53-53: Link to Ballerina Central for mi-module-gen is clear and actionable.The reference to the mi-module-gen tool on Ballerina Central (v0.4.3) helps users discover and verify the tool version, aligning with the PR goal.
66-66: Link to Ballerina Central for wso2/mi is consistent and helpful.The reference to the wso2/mi module (v0.4.0) on Ballerina Central allows users to explore the compiler plugin directly, supporting the documentation goal.
146-150: Clarify function modifier consistency in examples.The runtime example uses
remote function(line 147), but the compile-time validation examples usepublic function. This inconsistency could confuse users about which modifier to use when writing@mi:Operationfunctions.The distinction should clarify: are
remote functionexamples showing the generated connector output, or should users also write remote functions? If this is generated output, the example context could be clearer.Please clarify whether:
- Users should write
remoteorpublicfunctions with@mi:Operation- Whether the runtime example at line 147 represents generated connector code (in which case it should be labeled as such)
- Whether both modifiers are supported equally
84-162: Excellent comprehensive documentation of supported data types and runtime behavior.The new "Supported Data Types" section effectively documents compile-time validation constraints and runtime mapping behavior, directly addressing the PR objectives. The table format is clear, examples are practical, and the Ballerina Central links provide users with direct access to module specifications.
The separation between compile-time (wso2/mi plugin v0.4.0) and runtime (mi-module-gen v0.4.3) responsibilities is well-articulated, making the documentation precise and actionable.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Danesh Kuruppu <[email protected]>
Co-authored-by: Danesh Kuruppu <[email protected]>
Co-authored-by: Dilan Perera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Co-authored-by: Dilan Perera <[email protected]>
Co-authored-by: Dilan Perera <[email protected]>
RDPerera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
This PR addresses the need to clearly document the supported data types for Ballerina Module functions in WSO2 Integrator: MI. The documentation now explicitly describes which data types are supported at compile time (via the compiler plugin) and how they are mapped at runtime (via the mi-module-gen tool). This resolves issue #1897.
Goals
@mi:Operationannotated functions at compile timewso2/miv0.4.0) and module generator tool (mi_module_genv0.4.3)map<any>instead ofmap<...>)Approach
The documentation has been enhanced in the
ballerina-module/overview.mdfile with the following changes:Added Ballerina Central Links:
Enhanced Data Type Documentation:
...) with specific syntax ({ }for records,map<any>for maps)Improved Clarity:
User stories
@mi:Operationfunctions so I can write correct code that compiles successfullyRelease note
Enhanced Ballerina Module documentation with comprehensive data type support information, including compile-time validation and runtime mapping details. Added direct links to Ballerina Central for the compiler plugin and module generator tool.
Documentation
This PR directly updates the product documentation at:
en/docs/develop/customizations/ballerina-module/overview.mdThe changes improve the existing documentation by adding missing information about supported data types and providing direct links to related Ballerina Central packages.
Training
N/A - This is a documentation update that clarifies existing functionality. No training content changes are required.
Certification
N/A - This is a documentation enhancement that does not introduce new features or change existing behavior. The changes only clarify existing functionality.
Marketing
N/A - This is a documentation improvement that does not require marketing content.
Automation tests
Unit tests
N/A - Documentation-only change
Integration tests
N/A - Documentation-only change
Security checks
Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? N/A (Documentation-only change)
Ran FindSecurityBugs plugin and verified report? N/A (Documentation-only change)
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? Yes
Samples
N/A - This PR does not include or modify any code samples. The existing code examples in the documentation remain unchanged and continue to demonstrate the correct usage of supported data types.
Related PRs
None
Migrations (if applicable)
N/A - Documentation-only change, no migration required
Test environment
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.