-
Notifications
You must be signed in to change notification settings - Fork 82
Fix: Remove automatic input and output mapping generation statements [main] #1911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis update modifies documentation for data service creation, replacing sections describing optional mapping approaches with explicit step-by-step procedures for manually creating input and output mappings. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
en/docs/develop/creating-artifacts/data-services/creating-data-services.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
en/docs/develop/creating-artifacts/data-services/creating-data-services.md
173-173: Hard tabs
Column: 3
(MD010, no-hard-tabs)
🔇 Additional comments (2)
en/docs/develop/creating-artifacts/data-services/creating-data-services.md (2)
173-226: Input mapping section clearly directs manual configuration.The restructured section now explicitly guides users through manual input mapping creation with clear step-by-step instructions. The change removes any implication that mappings are automatically generated from the SQL query.
239-279: Output mapping section clearly directs manual configuration.The section now explicitly instructs users to manually add output mappings with detailed steps and examples. The language "To manually add the output mappings" unambiguously clarifies that this is a required manual process, not automatic.
|
|
||
| - You can use the default configurations to automatically generate the input mappings from the SQL query. | ||
| - If you want to add a new input mapping: | ||
| 2. To add a new input mapping: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace hard tabs with spaces (MD010 violation).
The indentation at line 173 uses hard tabs instead of spaces. Convert to spaces for consistency with Markdown linting standards.
🔎 Proposed fix
~
-2. To add a new input mapping:
+2. To add a new input mapping:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 2. To add a new input mapping: | |
| 2. To add a new input mapping: |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
173-173: Hard tabs
Column: 3
(MD010, no-hard-tabs)
🤖 Prompt for AI Agents
In en/docs/develop/creating-artifacts/data-services/creating-data-services.md
around line 173, the line "2. To add a new input mapping:" uses a hard tab for
indentation; replace the hard tab with spaces (use consistent spaces—e.g., 4
spaces or match surrounding file indentation) so the numbered list uses spaces
only and the MD010 lint violation is resolved.
This PR was automatically generated by Claude AI.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.