Skip to content

[3.0.0] Fix issue in JWT validation in consent validation endpoint #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ashi1993 wants to merge 4 commits into
base: 3.0.0
Choose a base branch
from
Open

[3.0.0] Fix issue in JWT validation in consent validation endpoint #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebe65f6
Improving Http client creation
Ashi1993 Apr 17, 2025
88d8a72
Merge remote-tracking branch 'upstream/3.0.0' into 3.0.0
Ashi1993 Jun 16, 2025
840fcc3
Merge remote-tracking branch 'upstream/3.0.0' into 3.0.0
Ashi1993 Sep 16, 2025
69e795f
Fix issue in JWT validation in consent validation endpoint
Ashi1993 Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...tity/src/main/java/com/wso2/openbanking/accelerator/identity/util/IdentityCommonUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,14 @@ public static boolean validateJWTSignatureWithPublicKey(String jwtString, String

try {
JWSVerifier verifier = new RSASSAVerifier((RSAPublicKey) publicKey);
return SignedJWT.parse(jwtString).verify(verifier);
boolean isValid = SignedJWT.parse(jwtString).verify(verifier);
if (!isValid) {
log.error("Invalid JWT signature");
throw new OpenBankingException("Invalid JWT signature");
} else {
log.debug("Returning true since the JWT signature is valid.");
return true;
}
} catch (JOSEException | ParseException e) {
throw new OpenBankingException("Error occurred while validating JWT signature");
}
Comment on lines 224 to 226
Copy link
Contributor

@wso2-engineering wso2-engineering bot Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log Improvement Suggestion No: 1

Suggested change
} catch (JOSEException | ParseException e) {
throw new OpenBankingException("Error occurred while validating JWT signature");
}
} catch (JOSEException | ParseException e) {
log.error("Error occurred while validating JWT signature: " + e.getMessage());
throw new OpenBankingException("Error occurred while validating JWT signature");

Expand Down
5 changes: 2 additions & 3 deletions ...java/com/wso2/openbanking/accelerator/consent/endpoint/api/ConsentValidationEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,10 @@ public Response validate(@Context HttpServletRequest request, @Context HttpServl
requestData = JWTUtils.decodeRequestJWT(payload, "body");
} catch (OpenBankingException e) {
log.error("Error while validating JWT signature", e);
throw new ConsentException(ResponseStatus.INTERNAL_SERVER_ERROR, "Error while validating JWT " +
"signature");
throw new ConsentException(ResponseStatus.INTERNAL_SERVER_ERROR, e.getMessage());
} catch (ParseException e) {
log.error("Error while decoding validation JWT", e);
throw new ConsentException(ResponseStatus.INTERNAL_SERVER_ERROR, "Error while decoding validation JWT");
throw new ConsentException(ResponseStatus.INTERNAL_SERVER_ERROR, e.getMessage());
}
} else {
try {
Expand Down