Fix: Enable concurrent operation of Resident and FS Key Managers for APIM Try Out compatibility

[VimukthiRajapaksha]

Purpose

This PR enables both Resident Key Manager and Financial Services Key Manager to be active simultaneously, resolving the limitation where users had to choose between OB compliance and APIM Try Out functionality.

Related Issues

#864

---

Development Checklist

1. Built complete solution with pull request in place.
2. Ran checkstyle plugin with pull request in place.
3. Ran Findbugs plugin with pull request in place.
4. Ran FindSecurityBugs plugin and verified report.
5. Formatted code according to WSO2 code style.
6. Have you verify the PR does't commit any keys, passwords, tokens, usernames, or other secrets?
7. Migration scripts written (if applicable).
8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

1. Written unit tests.
2. Documented test scenarios(link available in guides).
3. Written automation tests (link available in guides).
4. Verified tests in multiple database environments (if applicable).
5. Verified tests in multiple deployed specifications (if applicable).
6. Tested with OBBI enabled (if applicable).
7. Tested with specification regulatory conformance suites (if applicable).

Automation Test Details

Test Suite	Test Script IDs
Integration Suite	TCXXXXX, TCXXXX

Conformance Tests Details

Test Suite Name	Test Suite Version	Scenarios	Result
Security Suite	VX.X	Foo, Bar	Passed

Resources

Knowledge Base: https://sites.google.com/wso2.com/open-banking/

Guides: https://sites.google.com/wso2.com/open-banking/developer-guides

Summary by CodeRabbit

• Chores
  • Updated internal processing logic for service provider and application management operations to streamline the execution flow without prior conditional checks.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Removed regulatory gating logic from doPostGetServiceProvider and doPostDeleteApplication methods in the FSApplicationManagementListener. Both methods now directly invoke updater calls instead of conditionally returning early based on regulatory property checks.

Changes

Cohort / File(s)	Change Summary
Regulatory gating removal financial-services-accelerator/components/org.wso2.financial.services.accelerator.identity.extensions/src/main/java/org/wso2/financial/services/accelerator/identity/extensions/client/registration/application/listener/FSApplicationManagementListener.java	Removed regulatory property checks from doPostGetServiceProvider and doPostDeleteApplication methods. Both methods now proceed directly to updater method invocations without early returns based on regulatory status. Existing exception handling retained.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Regulatory logic removal implications: Verify why regulatory gating is being bypassed and whether this aligns with compliance requirements
• Method behavior change: Ensure the removal doesn't alter intended application lifecycle management for both service provider retrieval and deletion
• Downstream effects: Confirm updater methods can safely handle all application types without prior regulatory filtering

Poem

🐰 The gates of regulation fall away today,
Methods now proceed without delay,
Updaters called with newfound freedom's call,
Logic simplified—less checks to wall,
Simpler flows through hallways clear!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title describes enabling concurrent operation of two Key Managers, which directly relates to the core change of removing regulatory gating logic that prevented simultaneous activation.
Description check	✅ Passed	The description includes purpose, related issues, and development/secure checklists, though testing checklist items are unchecked with placeholder values in test details tables.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28e3027 and 293541f.

📒 Files selected for processing (1)

• financial-services-accelerator/components/org.wso2.financial.services.accelerator.identity.extensions/src/main/java/org/wso2/financial/services/accelerator/identity/extensions/client/registration/application/listener/FSApplicationManagementListener.java (0 hunks)

💤 Files with no reviewable changes (1)

• financial-services-accelerator/components/org.wso2.financial.services.accelerator.identity.extensions/src/main/java/org/wso2/financial/services/accelerator/identity/extensions/client/registration/application/listener/FSApplicationManagementListener.java

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[wso2-engineering]

AI Agent Log Improvement Checklist

⚠️ Warning: AI-Generated Review Comments

• The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
• Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.

✅ Before merging this pull request:

• Review all AI-generated comments for accuracy and relevance.
• Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.

Comment	Accepted (Y/N)	Reason
#### Log Improvement Suggestion No: 1
#### Log Improvement Suggestion No: 2