Skip to content

[OB4] Fix spotbugs issue in debug log #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imesh94 wants to merge 8 commits into from
Closed

[OB4] Fix spotbugs issue in debug log #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b6a8258
Fix spotbugs issue
imesh94 Dec 20, 2025
e4eeef7
Remove client id from debug log
imesh94 Dec 20, 2025
7ef98e3
Remove extra brackets
imesh94 Dec 20, 2025
138ba4a
Reformat debug log
imesh94 Dec 20, 2025
b792935
Remove debug log
imesh94 Dec 20, 2025
ae97f7d
Exclude CRLF_INJECTION_LOGS from spotbugs validations
imesh94 Dec 20, 2025
932a07b
Remove spotbugs crlf validation from IdentityCommonUtils class
imesh94 Dec 20, 2025
e18ce2b
Remove spotbugs crlf validation from Identity classes
imesh94 Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...tity/extensions/auth/extensions/request/validator/FSRequestObjectValidationExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

package org.wso2.financial.services.accelerator.identity.extensions.auth.extensions.request.validator;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import org.apache.commons.lang3.StringUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
Expand All @@ -44,6 +45,8 @@
* The extension of RequestObjectValidatorImpl to enforce Financial services specific validations of the
* request object.
*/
@SuppressFBWarnings(value = {"CRLF_INJECTION_LOGS", "REPLACE_STR_LINE_TERMINATORS"},
justification = "Log messages are sanitized for CRLF injection.")
public class FSRequestObjectValidationExtension extends RequestObjectValidatorImpl {

private static final Log log = LogFactory.getLog(FSRequestObjectValidationExtension.class);
Expand Down
3 changes: 3 additions & 0 deletions ...ntity/extensions/auth/extensions/response/handler/FSCodeResponseTypeHandlerExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.wso2.financial.services.accelerator.identity.extensions.auth.extensions.response.handler;

import com.fasterxml.jackson.core.JsonProcessingException;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.wso2.carbon.identity.oauth2.IdentityOAuth2Exception;
Expand All @@ -34,6 +35,8 @@
/**
* Extension to append scope with FS_ prefix at the end of auth flow, before offering auth code.
*/
@SuppressFBWarnings(value = {"CRLF_INJECTION_LOGS", "REPLACE_STR_LINE_TERMINATORS"},
justification = "Log messages are sanitized for CRLF injection.")
public class FSCodeResponseTypeHandlerExtension extends CodeResponseTypeHandler {

private static final Log log = LogFactory.getLog(FSCodeResponseTypeHandlerExtension.class);
Expand Down
3 changes: 3 additions & 0 deletions ...ity/extensions/auth/extensions/response/handler/FSHybridResponseTypeHandlerExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.wso2.financial.services.accelerator.identity.extensions.auth.extensions.response.handler;

import com.fasterxml.jackson.core.JsonProcessingException;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.wso2.carbon.identity.oauth2.IdentityOAuth2Exception;
Expand All @@ -34,6 +35,8 @@
/**
* Extension to append scope with FS_ prefix at the end of auth flow, before offering auth code.
*/
@SuppressFBWarnings(value = {"CRLF_INJECTION_LOGS", "REPLACE_STR_LINE_TERMINATORS"},
justification = "Log messages are sanitized for CRLF injection.")
public class FSHybridResponseTypeHandlerExtension extends HybridResponseTypeHandler {

private static final Log log = LogFactory.getLog(FSHybridResponseTypeHandlerExtension.class);
Expand Down
3 changes: 3 additions & 0 deletions ...l/services/accelerator/identity/extensions/claims/FSDefaultOIDCClaimsCallbackHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.wso2.financial.services.accelerator.identity.extensions.claims;

import com.nimbusds.jwt.JWTClaimsSet;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import org.apache.commons.lang3.StringUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
Expand All @@ -37,6 +38,8 @@
/**
* This call back handler adds FS specific additional claims to the self-contained JWT access token.
*/
@SuppressFBWarnings(value = {"CRLF_INJECTION_LOGS", "REPLACE_STR_LINE_TERMINATORS"},
justification = "Log messages are sanitized for CRLF injection.")
public class FSDefaultOIDCClaimsCallbackHandler extends DefaultOIDCClaimsCallbackHandler {

private static Log log = LogFactory.getLog(FSDefaultOIDCClaimsCallbackHandler.class);
Expand Down
3 changes: 3 additions & 0 deletions .../accelerator/identity/extensions/grant/type/handlers/FSAuthorizationCodeGrantHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

package org.wso2.financial.services.accelerator.identity.extensions.grant.type.handlers;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.wso2.carbon.identity.oauth2.IdentityOAuth2Exception;
Expand All @@ -37,6 +38,8 @@
* FS specific authorization code grant handler.
* main usage of extending is to handle the refresh token issuance and setting the refresh token validity period.
*/
@SuppressFBWarnings(value = {"CRLF_INJECTION_LOGS", "REPLACE_STR_LINE_TERMINATORS"},
justification = "Log messages are sanitized for CRLF injection.")
public class FSAuthorizationCodeGrantHandler extends AuthorizationCodeGrantHandler {

private static final Log log = LogFactory.getLog(FSAuthorizationCodeGrantHandler.class);
Expand Down
3 changes: 3 additions & 0 deletions ...l/services/accelerator/identity/extensions/grant/type/handlers/FSRefreshGrantHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

package org.wso2.financial.services.accelerator.identity.extensions.grant.type.handlers;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import org.apache.commons.lang3.ArrayUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
Expand All @@ -40,6 +41,8 @@
/**
* FS specific refresh grant handler.
*/
@SuppressFBWarnings(value = {"CRLF_INJECTION_LOGS", "REPLACE_STR_LINE_TERMINATORS"},
justification = "Log messages are sanitized for CRLF injection.")
public class FSRefreshGrantHandler extends RefreshGrantHandler {

private static final Log log = LogFactory.getLog(FSRefreshGrantHandler.class);
Expand Down
6 changes: 2 additions & 4 deletions ...org/wso2/financial/services/accelerator/identity/extensions/util/IdentityCommonUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@
/**
* Common utility class for Identity Extensions.
*/
@SuppressFBWarnings(value = {"CRLF_INJECTION_LOGS", "REPLACE_STR_LINE_TERMINATORS"},
justification = "Log messages are sanitized for CRLF injection.")
public class IdentityCommonUtils {

private static final Log log = LogFactory.getLog(IdentityCommonUtils.class);
Expand Down Expand Up @@ -378,10 +380,6 @@ public static boolean isRegulatoryApp(String clientId) throws FinancialServicesE
identityCache.addToCache(identityCacheKey, regulatoryProperty);
return Boolean.parseBoolean(regulatoryProperty.toString());
} else {
if (log.isDebugEnabled()) {
log.debug("Regulatory property not found in service provider metadata for clientId: "
+ clientId + ". Hence treating it as a non-regulatory application.");
}
return false;
}
} else {
Expand Down
Loading