Skip to content

[OB4] Fix build failure due to spotbugs CRLF validation #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amjadhifthikar merged 1 commit into from
Dec 20, 2025
Merged

[OB4] Fix build failure due to spotbugs CRLF validation #877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...org/wso2/financial/services/accelerator/identity/extensions/util/IdentityCommonUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,7 @@ public static boolean isRegulatoryApp(String clientId) throws FinancialServicesE
identityCache.addToCache(identityCacheKey, regulatoryProperty);
return Boolean.parseBoolean(regulatoryProperty.toString());
} else {
if (log.isDebugEnabled()) {
log.debug("Regulatory property not found in service provider metadata for clientId: "
+ clientId + ". Hence treating it as a non-regulatory application.");
}
log.debug("Regulatory property missing. Treating as non-regulatory application.");
Comment on lines 380 to +381
Copy link
Contributor

@wso2-engineering wso2-engineering bot Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log Improvement Suggestion No: 1

Suggested change
} else {
if (log.isDebugEnabled()) {
log.debug("Regulatory property not found in service provider metadata for clientId: "
+ clientId + ". Hence treating it as a non-regulatory application.");
}
log.debug("Regulatory property missing. Treating as non-regulatory application.");
} else {
if (log.isDebugEnabled()) {
log.debug("Regulatory property not found in service provider metadata for clientId: " + clientId + ". Treating as non-regulatory application.");
}

return false;
}
} else {
Expand Down
Loading