-
Notifications
You must be signed in to change notification settings - Fork 37
[OB3] Restrict token scopes based on scopes allowed for application #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
...o2/openbanking/accelerator/identity/grant/type/handlers/OBAuthorizationCodeGrantHandler.java
Show resolved
Hide resolved
...o2/openbanking/accelerator/identity/grant/type/handlers/OBAuthorizationCodeGrantHandler.java
Show resolved
Hide resolved
...o2/openbanking/accelerator/identity/grant/type/handlers/OBClientCredentialsGrantHandler.java
Show resolved
Hide resolved
...o2/openbanking/accelerator/identity/grant/type/handlers/OBClientCredentialsGrantHandler.java
Show resolved
Hide resolved
...va/com/wso2/openbanking/accelerator/identity/grant/type/handlers/OBPasswordGrantHandler.java
Show resolved
Hide resolved
...va/com/wso2/openbanking/accelerator/identity/grant/type/handlers/OBPasswordGrantHandler.java
Show resolved
Hide resolved
...ava/com/wso2/openbanking/accelerator/identity/grant/type/handlers/OBRefreshGrantHandler.java
Show resolved
Hide resolved
...ava/com/wso2/openbanking/accelerator/identity/grant/type/handlers/OBRefreshGrantHandler.java
Show resolved
Hide resolved
...in/java/com/wso2/openbanking/accelerator/identity/internal/IdentityExtensionsDataHolder.java
Show resolved
Hide resolved
...in/java/com/wso2/openbanking/accelerator/identity/internal/IdentityExtensionsDataHolder.java
Show resolved
Hide resolved
...dentity/src/main/java/com/wso2/openbanking/accelerator/identity/util/IdentityCommonUtil.java
Outdated
Show resolved
Hide resolved
...dentity/src/main/java/com/wso2/openbanking/accelerator/identity/util/IdentityCommonUtil.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
|
Shall we make this as follows to align more with other configs we have? |
5d9e981
Fixed by 5d9e981 |
[OB3] Restrict token scopes based on scopes allowed for application
Issue link: #872
Doc Issue: Optional, link issue from documentation repository
Applicable Labels: Spec, product, version, type (specify requested labels)
Development Checklist
Secure Development Checklist
Testing Checklist
Automation Test Details
Conformance Tests Details
Resources
Knowledge Base: https://sites.google.com/wso2.com/open-banking/
Guides: https://sites.google.com/wso2.com/open-banking/developer-guides