Skip to content

Conversation

@Akila94
Copy link
Member

@Akila94 Akila94 commented Jan 9, 2026

Allow to pass consent metadata to the JSP

Explain in a few lines the purpose of this pull request

Issue link: #881

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: OB4


Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

Summary by CodeRabbit

  • Bug Fixes
    • Fixed consent data handling to preserve metadata in authorization responses. Previously, metadata was being removed from consent data before returning it in API responses. The system now returns complete consent data including all metadata fields, ensuring downstream systems have access to complete information for processing, auditing, and compliance purposes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 9, 2026

Walkthrough

A metadata-stripping operation was removed from the ExternalAPIConsentRetrievalStep class, allowing CONSENT_METADATA to remain intact within consentDataJSON when attached to the response, rather than being discarded.

Changes

Cohort / File(s) Summary
Metadata Retention
financial-services-accelerator/components/org.wso2.financial.services.accelerator.consent.mgt.extensions/src/main/java/org/wso2/financial/services/accelerator/consent/mgt/extensions/authorize/impl/ExternalAPIConsentRetrievalStep.java
Removed 3 lines of code that stripped CONSENT_METADATA from consentDataJSON; metadata now persists in the response JSON structure

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hops of joy! No more stripping away,
Metadata whispers have come to stay,
In consent's embrace, the data shall dwell,
Preserved and protected—oh, what a swell!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is incomplete. It lacks the explanation of purpose, testing checklist items are partially unfilled, and no automation test or conformance test details are provided. Add a brief explanation of the change's purpose after the title, complete the testing checklist with details on unit tests and automation tests, and clarify whether conformance testing was performed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing metadata stripping to allow consent metadata to be passed to the JSP.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a2c45a and 2ce0edc.

📒 Files selected for processing (1)
  • financial-services-accelerator/components/org.wso2.financial.services.accelerator.consent.mgt.extensions/src/main/java/org/wso2/financial/services/accelerator/consent/mgt/extensions/authorize/impl/ExternalAPIConsentRetrievalStep.java
💤 Files with no reviewable changes (1)
  • financial-services-accelerator/components/org.wso2.financial.services.accelerator.consent.mgt.extensions/src/main/java/org/wso2/financial/services/accelerator/consent/mgt/extensions/authorize/impl/ExternalAPIConsentRetrievalStep.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@imesh94 imesh94 merged commit a3874cd into wso2:main Jan 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants