-
Notifications
You must be signed in to change notification settings - Fork 168
Add Action Type Pre-issue-id-token. #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Action Type Pre-issue-id-token. #1039
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds two new action types (AUTHENTICATION and PRE_ISSUE_ID_TOKEN) to the ActionType enum to support a dependency requirement in carbon-identity-framework PR #7639. However, the PR title and description only mention PRE_ISSUE_ID_TOKEN, creating a mismatch with the actual changes.
Key Changes:
- Added
AUTHENTICATIONandPRE_ISSUE_ID_TOKENenum values to ActionType.java
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public enum ActionType { | ||
|
|
||
| @XmlEnumValue("PRE_ISSUE_ACCESS_TOKEN") PRE_ISSUE_ACCESS_TOKEN(String.valueOf("PRE_ISSUE_ACCESS_TOKEN")), @XmlEnumValue("PRE_UPDATE_PASSWORD") PRE_UPDATE_PASSWORD(String.valueOf("PRE_UPDATE_PASSWORD")), @XmlEnumValue("PRE_UPDATE_PROFILE") PRE_UPDATE_PROFILE(String.valueOf("PRE_UPDATE_PROFILE")), @XmlEnumValue("PRE_REGISTRATION") PRE_REGISTRATION(String.valueOf("PRE_REGISTRATION")); | ||
| @XmlEnumValue("PRE_ISSUE_ACCESS_TOKEN") PRE_ISSUE_ACCESS_TOKEN(String.valueOf("PRE_ISSUE_ACCESS_TOKEN")), @XmlEnumValue("PRE_UPDATE_PASSWORD") PRE_UPDATE_PASSWORD(String.valueOf("PRE_UPDATE_PASSWORD")), @XmlEnumValue("PRE_UPDATE_PROFILE") PRE_UPDATE_PROFILE(String.valueOf("PRE_UPDATE_PROFILE")), @XmlEnumValue("PRE_REGISTRATION") PRE_REGISTRATION(String.valueOf("PRE_REGISTRATION")), @XmlEnumValue("PRE_ISSUE_ID_TOKEN") PRE_ISSUE_ID_TOKEN(String.valueOf("PRE_ISSUE_ID_TOKEN")); |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title mentions adding "PRE_ISSUE_ID_TOKEN" action type, but this change also adds "AUTHENTICATION" action type. Consider either:
- Updating the PR title and description to mention both action types being added, or
- If AUTHENTICATION was added in error, remove it from this change.
Additionally, note that since this is a generated file (in src/gen/java), the corresponding OpenAPI specification file (Actions.yaml) should be updated first, and this Java file should be regenerated from that specification to ensure consistency between the API contract and implementation.
Purpose of this PR is to add PRE_ISSUE_ID_TOKEN type for a dependency in
wso2/carbon-identity-framework#7639