-
Notifications
You must be signed in to change notification settings - Fork 168
Add new application property to refresh token. #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new application property to refresh token. #1041
Conversation
WalkthroughAdds a boolean OpenAPI field Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| consumerAppDTO.setRenewRefreshTokenEnabled(renewRefreshToken); | ||
| String extendRefreshTokenExpiryTime = refreshToken.getExtendRenewedRefreshTokenExpiryTime() != null ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log Improvement Suggestion No: 1
| consumerAppDTO.setRenewRefreshTokenEnabled(renewRefreshToken); | |
| String extendRefreshTokenExpiryTime = refreshToken.getExtendRenewedRefreshTokenExpiryTime() != null ? | |
| consumerAppDTO.setRenewRefreshTokenEnabled(renewRefreshToken); | |
| log.debug("Updated refresh token renewal configuration: " + renewRefreshToken); | |
| String extendRefreshTokenExpiryTime = refreshToken.getExtendRenewedRefreshTokenExpiryTime() != null ? |
...tion/management/v1/core/functions/application/inbound/oauth2/ApiModelToOAuthConsumerApp.java
Show resolved
Hide resolved
...tion/management/v1/core/functions/application/inbound/oauth2/OAuthConsumerAppToApiModel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 | ||
| #### Log Improvement Suggestion No: 2 | ||
| #### Log Improvement Suggestion No: 3 |
...org/wso2/carbon/identity/api/server/application/management/v1/RefreshTokenConfiguration.java
Outdated
Show resolved
Hide resolved
...o2.carbon.identity.api.server.application.management.v1/src/main/resources/applications.yaml
Outdated
Show resolved
Hide resolved
| String renewRefreshToken = refreshToken.getRenewRefreshToken() != null ? | ||
| String.valueOf(refreshToken.getRenewRefreshToken()) : null; | ||
| consumerAppDTO.setRenewRefreshTokenEnabled(renewRefreshToken); | ||
| String extendRefreshTokenExpiryTime = refreshToken.getExtendRenewedRefreshTokenExpiryTime() != null ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be a boolean instead of a String?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed the same pattern used for the renewRefreshToken property.
Purpose
Related issues
Before merge
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.